Update form styles, implement in many places
Summary: This creates a common form look and feel across the site. I spent a bit of time working out a number of kinks in our various renderings. Some things: - Font Styles are correctly applied for form elements now. - Everything lines up! - Selects are larger, easier to read, interact. - Inputs have been squared. - Consistant CSS applied glow (try it!) - Improved Mobile Responsiveness - CSS applied to all form elements, not just Aphront - Many other minor tweaks. I tried to hit as many high profile forms as possible in an effort to increase consistency. Stopped for now and will follow up after this lands. I know Evan is not a super fan of the glow, but after working with it for a week, it's way cleaner and responsive than the OS controls. Give it a try. Test Plan: Tested many applications, forms, mobile and tablet. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5860
This commit is contained in:
@@ -91,6 +91,7 @@ final class PhabricatorProjectMembersEditController
|
||||
$form = new AphrontFormView();
|
||||
$form
|
||||
->setUser($user)
|
||||
->setFlexible(true)
|
||||
->appendChild(
|
||||
id(new AphrontFormTokenizerControl())
|
||||
->setName('phids')
|
||||
@@ -101,24 +102,21 @@ final class PhabricatorProjectMembersEditController
|
||||
->addCancelButton('/project/view/'.$project->getID().'/')
|
||||
->setValue(pht('Add Members')));
|
||||
$faux_form = id(new AphrontFormLayoutView())
|
||||
->setBackgroundShading(true)
|
||||
->setPadded(true)
|
||||
->appendChild(
|
||||
id(new AphrontFormInsetView())
|
||||
->setTitle(pht('Current Members (%d)', count($handles)))
|
||||
->appendChild($list));
|
||||
|
||||
$panel = new AphrontPanelView();
|
||||
$panel->setHeader($header_name);
|
||||
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
|
||||
$panel->setNoBackground();
|
||||
$panel->appendChild($form);
|
||||
$panel->appendChild(phutil_tag('br'));
|
||||
$panel->appendChild($faux_form);
|
||||
$box = new PHUIBoxView();
|
||||
$box->appendChild($faux_form);
|
||||
$box->setShadow(true);
|
||||
$box->addPadding(PHUI::PADDING_LARGE);
|
||||
$box->addMargin(PHUI::MARGIN_LARGE);
|
||||
|
||||
$nav = $this->buildLocalNavigation($project);
|
||||
$nav->selectFilter('members');
|
||||
$nav->appendChild($panel);
|
||||
$nav->appendChild($form);
|
||||
$nav->appendChild($box);
|
||||
|
||||
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
|
||||
$crumbs->addCrumb(
|
||||
@@ -136,6 +134,7 @@ final class PhabricatorProjectMembersEditController
|
||||
array(
|
||||
'title' => $title,
|
||||
'device' => true,
|
||||
'dust' => true,
|
||||
));
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user