Update form styles, implement in many places

Summary:
This creates a common form look and feel across the site. I spent a bit of time working out a number of kinks in our various renderings. Some things:

- Font Styles are correctly applied for form elements now.
- Everything lines up!
- Selects are larger, easier to read, interact.
- Inputs have been squared.
- Consistant CSS applied glow (try it!)
- Improved Mobile Responsiveness
- CSS applied to all form elements, not just Aphront
- Many other minor tweaks.

I tried to hit as many high profile forms as possible in an effort to increase consistency. Stopped for now and will follow up after this lands. I know Evan is not a super fan of the glow, but after working with it for a week, it's way cleaner and responsive than the OS controls. Give it a try.

Test Plan: Tested many applications, forms, mobile and tablet.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5860
This commit is contained in:
Chad Little
2013-05-07 14:07:06 -07:00
parent 7533d498ba
commit 43ff24b0f3
32 changed files with 415 additions and 288 deletions

View File

@@ -71,6 +71,7 @@ final class PhabricatorRepositoryCreateController
$form
->setUser($user)
->setAction('/repository/create/')
->setFlexible(true)
->appendChild(
id(new AphrontFormTextControl())
->setLabel('Name')
@@ -102,19 +103,19 @@ final class PhabricatorRepositoryCreateController
->setValue('Create Repository')
->addCancelButton('/repository/'));
$panel = new AphrontPanelView();
$panel->setHeader('Create Repository');
$panel->appendChild($form);
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
$panel->setNoBackground();
$header = id(new PhabricatorHeaderView())
->setHeader(pht('Create Repository'));
return $this->buildStandardPageResponse(
return $this->buildApplicationPage(
array(
$error_view,
$panel,
$header,
$form,
),
array(
'title' => 'Create Repository',
'title' => pht('Create Repository'),
'device' => true,
'dust' => true,
));
}