archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

[Redesign] New PHUIObjectItemListView

Browse Source 
Summary:
New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:

 - Remove FootIcons
 - Remove Stackable
 - Remove Plain List
 - Add StatusIcon
 - Add setting ObjectList to an ObjectBox
 - Minor retouches to Headers

Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.

Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12865
This commit is contained in:
Chad Little
2015-05-15 13:28:59 -07:00
parent b1b97dddc7
commit 46f6c2680e
25 changed files with 280 additions and 315 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/applications/home/controller/PhabricatorHomeMainController.php
View File

@@ -152,7 +152,7 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
$title = pht('Unbreak Now!');
$panel = new PHUIObjectBoxView();
$panel->setHeader($this->renderSectionHeader($title, $href));
$panel->appendChild($this->buildTaskListView($tasks));
$panel->setObjectList($this->buildTaskListView($tasks));
return $panel;
}
@@ -202,7 +202,7 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
$user->getPHID());
$panel = new PHUIObjectBoxView();
$panel->setHeader($this->renderSectionHeader($title, $href));
$panel->appendChild($this->buildTaskListView($tasks));
$panel->setObjectList($this->buildTaskListView($tasks));
return $panel;
}
@@ -248,9 +248,8 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
$revision_view->setHandles($handles);
$list_view = $revision_view->render();
$list_view->setFlush(true);
$panel->appendChild($list_view);
$panel->setObjectList($list_view);
return $panel;
}
@@ -290,7 +289,7 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
$href = '/maniphest/query/assigned/';
$panel = new PHUIObjectBoxView();
$panel->setHeader($this->renderSectionHeader($title, $href));
$panel->appendChild($this->buildTaskListView($tasks));
$panel->setObjectList($this->buildTaskListView($tasks));
return $panel;
}
@@ -375,7 +374,7 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
$href = '/audit/';
$panel = new PHUIObjectBoxView();
$panel->setHeader($this->renderSectionHeader($title, $href));
$panel->appendChild($view);
$panel->setObjectList($view);
return $panel;
}
@@ -414,7 +413,7 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
$href = '/audit/';
$panel = new PHUIObjectBoxView();
$panel->setHeader($this->renderSectionHeader($title, $href));
$panel->appendChild($view);
$panel->setObjectList($view);
return $panel;
}