Allow workboard background colors to be configured
Summary:
Adds a UI for selecting background colors.
You can choose "Use Parent", which is the default, and allows you to set a color that all descendants inherit.
You can also choose "None", if a parent has a WHACKY BACKGROUND that you refuse to put up with.
Test Plan:
{F1114588}
{F1114589}
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D15279
This commit is contained in:
@@ -0,0 +1,168 @@
|
||||
<?php
|
||||
|
||||
final class PhabricatorProjectBoardBackgroundController
|
||||
extends PhabricatorProjectBoardController {
|
||||
|
||||
public function handleRequest(AphrontRequest $request) {
|
||||
$viewer = $request->getUser();
|
||||
$board_id = $request->getURIData('projectID');
|
||||
|
||||
$board = id(new PhabricatorProjectQuery())
|
||||
->setViewer($viewer)
|
||||
->withIDs(array($board_id))
|
||||
->needImages(true)
|
||||
->requireCapabilities(
|
||||
array(
|
||||
PhabricatorPolicyCapability::CAN_VIEW,
|
||||
PhabricatorPolicyCapability::CAN_EDIT,
|
||||
))
|
||||
->executeOne();
|
||||
if (!$board) {
|
||||
return new Aphront404Response();
|
||||
}
|
||||
|
||||
if (!$board->getHasWorkboard()) {
|
||||
return new Aphront404Response();
|
||||
}
|
||||
|
||||
$this->setProject($board);
|
||||
$id = $board->getID();
|
||||
|
||||
$manage_uri = $this->getApplicationURI("board/{$id}/manage/");
|
||||
|
||||
if ($request->isFormPost()) {
|
||||
$background_key = $request->getStr('backgroundKey');
|
||||
|
||||
$xactions = array();
|
||||
|
||||
$xactions[] = id(new PhabricatorProjectTransaction())
|
||||
->setTransactionType(PhabricatorProjectTransaction::TYPE_BACKGROUND)
|
||||
->setNewValue($background_key);
|
||||
|
||||
id(new PhabricatorProjectTransactionEditor())
|
||||
->setActor($viewer)
|
||||
->setContentSourceFromRequest($request)
|
||||
->setContinueOnNoEffect(true)
|
||||
->setContinueOnMissingFields(true)
|
||||
->applyTransactions($board, $xactions);
|
||||
|
||||
return id(new AphrontRedirectResponse())
|
||||
->setURI($manage_uri);
|
||||
}
|
||||
|
||||
$nav = $this->getProfileMenu();
|
||||
|
||||
$crumbs = id($this->buildApplicationCrumbs())
|
||||
->addTextCrumb(pht('Workboard'), "/project/board/{$board_id}/")
|
||||
->addTextCrumb(pht('Manage'), $manage_uri)
|
||||
->addTextCrumb(pht('Background Color'));
|
||||
|
||||
$form = id(new AphrontFormView())
|
||||
->setUser($viewer);
|
||||
|
||||
$group_info = array(
|
||||
'basic' => array(
|
||||
'label' => pht('Basics'),
|
||||
),
|
||||
'solid' => array(
|
||||
'label' => pht('Solid Colors'),
|
||||
),
|
||||
'gradient' => array(
|
||||
'label' => pht('Gradients'),
|
||||
),
|
||||
);
|
||||
|
||||
$groups = array();
|
||||
$options = PhabricatorProjectWorkboardBackgroundColor::getOptions();
|
||||
$option_groups = igroup($options, 'group');
|
||||
|
||||
require_celerity_resource('people-profile-css');
|
||||
require_celerity_resource('phui-workboard-color-css');
|
||||
Javelin::initBehavior('phabricator-tooltips', array());
|
||||
|
||||
foreach ($group_info as $group_key => $spec) {
|
||||
$buttons = array();
|
||||
|
||||
$available_options = idx($option_groups, $group_key, array());
|
||||
foreach ($available_options as $option) {
|
||||
$buttons[] = $this->renderOptionButton($option);
|
||||
}
|
||||
|
||||
$form->appendControl(
|
||||
id(new AphrontFormMarkupControl())
|
||||
->setLabel($spec['label'])
|
||||
->setValue($buttons));
|
||||
}
|
||||
|
||||
// NOTE: Each button is its own form, so we can't wrap them in a normal
|
||||
// form.
|
||||
$layout_view = $form->buildLayoutView();
|
||||
|
||||
$form_box = id(new PHUIObjectBoxView())
|
||||
->setHeaderText(pht('Edit Background Color'))
|
||||
->appendChild($layout_view);
|
||||
|
||||
return $this->newPage()
|
||||
->setTitle(
|
||||
array(
|
||||
pht('Edit Background Color'),
|
||||
$board->getDisplayName(),
|
||||
))
|
||||
->setCrumbs($crumbs)
|
||||
->setNavigation($nav)
|
||||
->appendChild($form_box);
|
||||
}
|
||||
|
||||
private function renderOptionButton(array $option) {
|
||||
$viewer = $this->getViewer();
|
||||
|
||||
$icon = idx($option, 'icon');
|
||||
if ($icon) {
|
||||
$preview_class = null;
|
||||
$preview_content = id(new PHUIIconView())
|
||||
->setIcon($icon, 'lightbluetext');
|
||||
} else {
|
||||
$preview_class = 'phui-workboard-'.$option['key'];
|
||||
$preview_content = null;
|
||||
}
|
||||
|
||||
$preview = phutil_tag(
|
||||
'div',
|
||||
array(
|
||||
'class' => 'phui-workboard-color-preview '.$preview_class,
|
||||
),
|
||||
$preview_content);
|
||||
|
||||
$button = javelin_tag(
|
||||
'button',
|
||||
array(
|
||||
'class' => 'grey profile-image-button',
|
||||
'sigil' => 'has-tooltip',
|
||||
'meta' => array(
|
||||
'tip' => $option['name'],
|
||||
'size' => 300,
|
||||
),
|
||||
),
|
||||
$preview);
|
||||
|
||||
$input = phutil_tag(
|
||||
'input',
|
||||
array(
|
||||
'type' => 'hidden',
|
||||
'name' => 'backgroundKey',
|
||||
'value' => $option['key'],
|
||||
));
|
||||
|
||||
return phabricator_form(
|
||||
$viewer,
|
||||
array(
|
||||
'class' => 'profile-image-form',
|
||||
'method' => 'POST',
|
||||
),
|
||||
array(
|
||||
$button,
|
||||
$input,
|
||||
));
|
||||
}
|
||||
|
||||
}
|
||||
@@ -96,6 +96,16 @@ final class PhabricatorProjectBoardManageController
|
||||
->setDisabled(!$can_edit)
|
||||
->setWorkflow(true));
|
||||
|
||||
$background_uri = $this->getApplicationURI("board/{$id}/background/");
|
||||
|
||||
$actions->addAction(
|
||||
id(new PhabricatorActionView())
|
||||
->setIcon('fa-paint-brush')
|
||||
->setName(pht('Change Background Color'))
|
||||
->setHref($background_uri)
|
||||
->setDisabled(!$can_edit)
|
||||
->setWorkflow(!$can_edit));
|
||||
|
||||
$disable_uri = $this->getApplicationURI("board/{$id}/disable/");
|
||||
|
||||
$actions->addAction(
|
||||
@@ -117,6 +127,15 @@ final class PhabricatorProjectBoardManageController
|
||||
->setUser($viewer)
|
||||
->setObject($board);
|
||||
|
||||
$background = $board->getDisplayWorkboardBackgroundColor();
|
||||
if ($background !== null) {
|
||||
$map = PhabricatorProjectWorkboardBackgroundColor::getOptions();
|
||||
$map = ipull($map, 'name');
|
||||
|
||||
$name = idx($map, $background, $background);
|
||||
$properties->addProperty(pht('Background Color'), $name);
|
||||
}
|
||||
|
||||
return $properties;
|
||||
}
|
||||
|
||||
|
||||
@@ -431,12 +431,7 @@ final class PhabricatorProjectBoardViewController
|
||||
$crumbs->addAction($manage_menu);
|
||||
$crumbs->addAction($fullscreen);
|
||||
|
||||
// TODO: Wire to Workboard Preferences
|
||||
// require_celerity_resource('phui-workboard-color-css');
|
||||
// ->addClass('phui-workboard-color')
|
||||
// ->addClass('phui-workboard-bluegrey')
|
||||
|
||||
return $this->newPage()
|
||||
$page = $this->newPage()
|
||||
->setTitle(
|
||||
array(
|
||||
$project->getDisplayName(),
|
||||
@@ -454,6 +449,17 @@ final class PhabricatorProjectBoardViewController
|
||||
array(
|
||||
$board_box,
|
||||
));
|
||||
|
||||
$background = $project->getDisplayWorkboardBackgroundColor();
|
||||
if ($background !== null) {
|
||||
require_celerity_resource('phui-workboard-color-css');
|
||||
$background_color_class = "phui-workboard-{$background}";
|
||||
|
||||
$page->addClass('phui-workboard-color');
|
||||
$nav->addClass($background_color_class);
|
||||
}
|
||||
|
||||
return $page;
|
||||
}
|
||||
|
||||
private function readRequestState() {
|
||||
|
||||
Reference in New Issue
Block a user