archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Drop nonsense buildStatus field from Buildable

Browse Source 
Summary:
Ref T4809. Buildables currently have buildStatus and buildableStatus. Neither are used, and no one knows why we have two.

I'm going to use buildableStatus shortly, but buildStatus is meaningless; burn it.

Test Plan: `grep`, examined similar get/set calls, created a new buildable, ran storage upgrade.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4809

Differential Revision: https://secure.phabricator.com/D8796
This commit is contained in:
epriestley
2014-04-17 16:01:06 -07:00
parent 7c1bcdea16
commit 4918773afe
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
resources/sql/autopatches/20140416.harbor.1.sql Normal file
View File

@@ -0,0 +1,2 @@
ALTER TABLE {$NAMESPACE}_harbormaster.harbormaster_buildable
DROP buildStatus;

2
src/applications/harbormaster/storage/HarbormasterBuildable.php
View File

@@ -7,7 +7,6 @@ final class HarbormasterBuildable extends HarbormasterDAO
protected $buildablePHID; protected $buildablePHID;
protected $containerPHID; protected $containerPHID;
protected $buildStatus;
protected $buildableStatus; protected $buildableStatus;
protected $isManualBuildable; protected $isManualBuildable;
@@ -22,7 +21,6 @@ final class HarbormasterBuildable extends HarbormasterDAO
public static function initializeNewBuildable(PhabricatorUser $actor) { public static function initializeNewBuildable(PhabricatorUser $actor) {
return id(new HarbormasterBuildable()) return id(new HarbormasterBuildable())
->setIsManualBuildable(0) ->setIsManualBuildable(0)
->setBuildStatus(self::STATUS_WHATEVER)
->setBuildableStatus(self::STATUS_WHATEVER); ->setBuildableStatus(self::STATUS_WHATEVER);
} }