Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract

Summary: Fixes T9625. As explained in a `TODO` comment, seems reasonable enough.

Test Plan: Unit tests.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, hach-que

Maniphest Tasks: T9625

Differential Revision: https://secure.phabricator.com/D14068

src/applications/almanac/phid/AlmanacBindingPHIDType.php

@@ -12,6 +12,10 @@ final class AlmanacBindingPHIDType extends PhabricatorPHIDType {
     return new AlmanacBinding();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorAlmanacApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/almanac/phid/AlmanacDevicePHIDType.php

@@ -12,6 +12,10 @@ final class AlmanacDevicePHIDType extends PhabricatorPHIDType {
     return new AlmanacDevice();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorAlmanacApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/almanac/phid/AlmanacInterfacePHIDType.php

@@ -12,6 +12,10 @@ final class AlmanacInterfacePHIDType extends PhabricatorPHIDType {
     return new AlmanacInterface();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorAlmanacApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/almanac/phid/AlmanacNetworkPHIDType.php

@@ -12,6 +12,10 @@ final class AlmanacNetworkPHIDType extends PhabricatorPHIDType {
     return new AlmanacNetwork();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorAlmanacApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/almanac/phid/AlmanacServicePHIDType.php

@@ -12,6 +12,10 @@ final class AlmanacServicePHIDType extends PhabricatorPHIDType {
     return new AlmanacService();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorAlmanacApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/auth/phid/PhabricatorAuthAuthFactorPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorAuthAuthFactorPHIDType extends PhabricatorPHIDType {
     return new PhabricatorAuthFactorConfig();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorAuthApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorAuthAuthProviderPHIDType extends PhabricatorPHIDType {
     return new PhabricatorAuthProviderConfig();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorAuthApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/auth/phid/PhabricatorAuthInvitePHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorAuthInvitePHIDType extends PhabricatorPHIDType {
     return new PhabricatorAuthInvite();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorAuthApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php

@@ -8,14 +8,14 @@ final class PhabricatorCalendarEventPHIDType extends PhabricatorPHIDType {
     return pht('Event');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorCalendarApplication';
-  }
-
   public function newObject() {
     return new PhabricatorCalendarEvent();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorCalendarApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/config/phid/PhabricatorConfigConfigPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorConfigConfigPHIDType extends PhabricatorPHIDType {
     return new PhabricatorConfigEntry();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorConfigApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorCountdownCountdownPHIDType extends PhabricatorPHIDType {
     return new PhabricatorCountdown();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorCountdownApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/dashboard/phid/PhabricatorDashboardDashboardPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorDashboardDashboardPHIDType extends PhabricatorPHIDType {
     return new PhabricatorDashboard();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDashboardApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/dashboard/phid/PhabricatorDashboardPanelPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorDashboardPanelPHIDType extends PhabricatorPHIDType {
     return new PhabricatorDashboardPanel();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDashboardApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/differential/phid/DifferentialDiffPHIDType.php

@@ -12,6 +12,10 @@ final class DifferentialDiffPHIDType extends PhabricatorPHIDType {
     return new DifferentialDiff();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDifferentialApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/differential/phid/DifferentialRevisionPHIDType.php

@@ -8,14 +8,14 @@ final class DifferentialRevisionPHIDType extends PhabricatorPHIDType {
     return pht('Differential Revision');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorDifferentialApplication';
-  }
-
   public function newObject() {
     return new DifferentialRevision();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDifferentialApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/drydock/phid/DrydockAuthorizationPHIDType.php

@@ -12,6 +12,10 @@ final class DrydockAuthorizationPHIDType extends PhabricatorPHIDType {
     return new DrydockAuthorization();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDrydockApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/drydock/phid/DrydockBlueprintPHIDType.php

@@ -8,10 +8,6 @@ final class DrydockBlueprintPHIDType extends PhabricatorPHIDType {
     return pht('Blueprint');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorDrydockApplication';
-  }
-
   public function getTypeIcon() {
     return 'fa-map-o';
   }
@@ -20,6 +16,10 @@ final class DrydockBlueprintPHIDType extends PhabricatorPHIDType {
     return new DrydockBlueprint();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDrydockApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/drydock/phid/DrydockLeasePHIDType.php

@@ -8,10 +8,6 @@ final class DrydockLeasePHIDType extends PhabricatorPHIDType {
     return pht('Drydock Lease');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorDrydockApplication';
-  }
-
   public function getTypeIcon() {
     return 'fa-link';
   }
@@ -20,6 +16,10 @@ final class DrydockLeasePHIDType extends PhabricatorPHIDType {
     return new DrydockLease();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDrydockApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/drydock/phid/DrydockRepositoryOperationPHIDType.php

@@ -12,6 +12,10 @@ final class DrydockRepositoryOperationPHIDType extends PhabricatorPHIDType {
     return new DrydockRepositoryOperation();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDrydockApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/drydock/phid/DrydockResourcePHIDType.php

@@ -8,10 +8,6 @@ final class DrydockResourcePHIDType extends PhabricatorPHIDType {
     return pht('Drydock Resource');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorDrydockApplication';
-  }
-
   public function getTypeIcon() {
     return 'fa-map';
   }
@@ -20,6 +16,10 @@ final class DrydockResourcePHIDType extends PhabricatorPHIDType {
     return new DrydockResource();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDrydockApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/files/phid/PhabricatorFileFilePHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorFileFilePHIDType extends PhabricatorPHIDType {
     return new PhabricatorFile();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorFilesApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/fund/phid/FundBackerPHIDType.php

@@ -12,6 +12,10 @@ final class FundBackerPHIDType extends PhabricatorPHIDType {
     return new FundInitiative();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorFundApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/harbormaster/phid/HarbormasterBuildArtifactPHIDType.php

@@ -12,6 +12,10 @@ final class HarbormasterBuildArtifactPHIDType extends PhabricatorPHIDType {
     return new HarbormasterBuildArtifact();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorHarbormasterApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/harbormaster/phid/HarbormasterBuildLogPHIDType.php

@@ -12,6 +12,10 @@ final class HarbormasterBuildLogPHIDType extends PhabricatorPHIDType {
     return new HarbormasterBuildLog();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorHarbormasterApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/harbormaster/phid/HarbormasterBuildPHIDType.php

@@ -12,6 +12,10 @@ final class HarbormasterBuildPHIDType extends PhabricatorPHIDType {
     return new HarbormasterBuild();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorHarbormasterApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/harbormaster/phid/HarbormasterBuildPlanPHIDType.php

@@ -16,6 +16,10 @@ final class HarbormasterBuildPlanPHIDType extends PhabricatorPHIDType {
     return new HarbormasterBuildPlan();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorHarbormasterApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/harbormaster/phid/HarbormasterBuildStepPHIDType.php

@@ -12,6 +12,10 @@ final class HarbormasterBuildStepPHIDType extends PhabricatorPHIDType {
     return new HarbormasterBuildStep();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorHarbormasterApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/harbormaster/phid/HarbormasterBuildTargetPHIDType.php

@@ -12,6 +12,10 @@ final class HarbormasterBuildTargetPHIDType extends PhabricatorPHIDType {
     return new HarbormasterBuildTarget();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorHarbormasterApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/harbormaster/phid/HarbormasterBuildablePHIDType.php

@@ -12,6 +12,10 @@ final class HarbormasterBuildablePHIDType extends PhabricatorPHIDType {
     return new HarbormasterBuildable();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorHarbormasterApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/herald/phid/HeraldRulePHIDType.php

@@ -12,6 +12,10 @@ final class HeraldRulePHIDType extends PhabricatorPHIDType {
     return new HeraldRule();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorHeraldApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/legalpad/phid/PhabricatorLegalpadDocumentPHIDType.php

@@ -16,6 +16,10 @@ final class PhabricatorLegalpadDocumentPHIDType extends PhabricatorPHIDType {
     return new LegalpadDocument();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorLegalpadApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/maniphest/phid/ManiphestTaskPHIDType.php

@@ -8,14 +8,14 @@ final class ManiphestTaskPHIDType extends PhabricatorPHIDType {
     return pht('Maniphest Task');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorManiphestApplication';
-  }
-
   public function newObject() {
     return new ManiphestTask();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorManiphestApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/meta/phid/PhabricatorApplicationApplicationPHIDType.php

@@ -17,6 +17,10 @@ final class PhabricatorApplicationApplicationPHIDType
     return null;
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorApplicationsApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/metamta/phid/PhabricatorMetaMTAMailPHIDType.php

@@ -8,14 +8,14 @@ final class PhabricatorMetaMTAMailPHIDType extends PhabricatorPHIDType {
     return pht('MetaMTA Mail');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorMetaMTAApplication';
-  }
-
   public function newObject() {
     return new PhabricatorMetaMTAMail();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorMetaMTAApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/nuance/phid/NuanceItemPHIDType.php

@@ -12,6 +12,10 @@ final class NuanceItemPHIDType extends PhabricatorPHIDType {
     return new NuanceItem();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorNuanceApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/nuance/phid/NuanceQueuePHIDType.php

@@ -12,6 +12,10 @@ final class NuanceQueuePHIDType extends PhabricatorPHIDType {
     return new NuanceQueue();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorNuanceApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/nuance/phid/NuanceRequestorPHIDType.php

@@ -12,6 +12,10 @@ final class NuanceRequestorPHIDType extends PhabricatorPHIDType {
     return new NuanceRequestor();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorNuanceApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/nuance/phid/NuanceSourcePHIDType.php

@@ -12,6 +12,10 @@ final class NuanceSourcePHIDType extends PhabricatorPHIDType {
     return new NuanceSource();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorNuanceApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/oauthserver/phid/PhabricatorOAuthServerClientAuthorizationPHIDType.php

@@ -13,6 +13,10 @@ final class PhabricatorOAuthServerClientAuthorizationPHIDType
     return new PhabricatorOAuthClientAuthorization();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorOAuthServerApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/oauthserver/phid/PhabricatorOAuthServerClientPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorOAuthServerClientPHIDType extends PhabricatorPHIDType {
     return new PhabricatorOAuthServerClient();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorOAuthServerApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/owners/phid/PhabricatorOwnersPackagePHIDType.php

@@ -16,6 +16,10 @@ final class PhabricatorOwnersPackagePHIDType extends PhabricatorPHIDType {
     return new PhabricatorOwnersPackage();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorOwnersApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/paste/phid/PhabricatorPastePastePHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorPastePastePHIDType extends PhabricatorPHIDType {
     return new PhabricatorPaste();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPasteApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/people/phid/PhabricatorPeopleExternalPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorPeopleExternalPHIDType extends PhabricatorPHIDType {
     return new PhabricatorExternalAccount();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPeopleApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/people/phid/PhabricatorPeopleUserPHIDType.php

@@ -8,10 +8,6 @@ final class PhabricatorPeopleUserPHIDType extends PhabricatorPHIDType {
     return pht('User');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorPeopleApplication';
-  }
-
   public function getTypeIcon() {
     return 'fa-user bluegrey';
   }
@@ -20,6 +16,10 @@ final class PhabricatorPeopleUserPHIDType extends PhabricatorPHIDType {
     return new PhabricatorUser();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPeopleApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phame/phid/PhabricatorPhameBlogPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorPhameBlogPHIDType extends PhabricatorPHIDType {
     return new PhameBlog();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhameApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phame/phid/PhabricatorPhamePostPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorPhamePostPHIDType extends PhabricatorPHIDType {
     return new PhamePost();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhameApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phid/PhabricatorMetaMTAApplicationEmailPHIDType.php

@@ -9,10 +9,6 @@ final class PhabricatorMetaMTAApplicationEmailPHIDType
     return pht('Application Email');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorMetaMTAApplication';
-  }
-
   public function getTypeIcon() {
     return 'fa-email bluegrey';
   }
@@ -21,6 +17,10 @@ final class PhabricatorMetaMTAApplicationEmailPHIDType
     return new PhabricatorMetaMTAApplicationEmail();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorMetaMTAApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phid/type/PhabricatorPHIDType.php

@@ -20,10 +20,6 @@ abstract class PhabricatorPHIDType extends Phobject {
 
   abstract public function getTypeName();
 
-  public function newObject() {
-    return null;
-  }
-
   public function getTypeIcon() {
     // Default to the application icon if the type doesn't specify one.
     $application_class = $this->getPHIDTypeApplicationClass();
@@ -35,6 +31,10 @@ abstract class PhabricatorPHIDType extends Phobject {
     return null;
   }
 
+  public function newObject() {
+    return null;
+  }
+
 
   /**
    * Get the class name for the application this type belongs to.
@@ -42,12 +42,7 @@ abstract class PhabricatorPHIDType extends Phobject {
    * @return string|null Class name of the corresponding application, or null
    *   if the type is not bound to an application.
    */
-  public function getPHIDTypeApplicationClass() {
-    // TODO: Some day this should probably be abstract, but for now it only
-    // affects global search and there's no real burning need to go classify
-    // every PHID type.
-    return null;
-  }
+  abstract public function getPHIDTypeApplicationClass();
 
   /**
    * Build a @{class:PhabricatorPolicyAwareQuery} to load objects of this type

src/applications/phid/type/__tests__/PhabricatorPHIDTypeTestCase.php

@@ -7,4 +7,16 @@ final class PhabricatorPHIDTypeTestCase extends PhutilTestCase {
     $this->assertTrue(true);
   }
 
+  public function testGetPHIDTypeApplicationClass() {
+    $types = PhabricatorPHIDType::getAllTypes();
+
+    foreach ($types as $type) {
+      $application_class = $type->getPHIDTypeApplicationClass();
+
+      if ($application_class !== null) {
+        $this->assertTrue(class_exists($application_class));
+      }
+    }
+  }
+
 }

src/applications/phlux/phid/PhluxVariablePHIDType.php

@@ -12,6 +12,10 @@ final class PhluxVariablePHIDType extends PhabricatorPHIDType {
     return new PhluxVariable();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhluxApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/pholio/phid/PholioImagePHIDType.php

@@ -12,6 +12,10 @@ final class PholioImagePHIDType extends PhabricatorPHIDType {
     return new PholioImage();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPholioApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/pholio/phid/PholioMockPHIDType.php

@@ -8,14 +8,14 @@ final class PholioMockPHIDType extends PhabricatorPHIDType {
     return pht('Pholio Mock');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorPholioApplication';
-  }
-
   public function newObject() {
     return new PholioMock();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPholioApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phortune/phid/PhortuneAccountPHIDType.php

@@ -12,6 +12,10 @@ final class PhortuneAccountPHIDType extends PhabricatorPHIDType {
     return new PhortuneAccount();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhortuneApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phortune/phid/PhortuneCartPHIDType.php

@@ -12,6 +12,10 @@ final class PhortuneCartPHIDType extends PhabricatorPHIDType {
     return new PhortuneCart();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhortuneApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phortune/phid/PhortuneChargePHIDType.php

@@ -12,6 +12,10 @@ final class PhortuneChargePHIDType extends PhabricatorPHIDType {
     return new PhortuneCharge();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhortuneApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phortune/phid/PhortuneMerchantPHIDType.php

@@ -12,6 +12,10 @@ final class PhortuneMerchantPHIDType extends PhabricatorPHIDType {
     return new PhortuneMerchant();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhortuneApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phortune/phid/PhortunePaymentMethodPHIDType.php

@@ -12,6 +12,10 @@ final class PhortunePaymentMethodPHIDType extends PhabricatorPHIDType {
     return new PhortunePaymentMethod();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhortuneApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phortune/phid/PhortunePaymentProviderPHIDType.php

@@ -12,6 +12,10 @@ final class PhortunePaymentProviderPHIDType extends PhabricatorPHIDType {
     return new PhortunePaymentProviderConfig();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhortuneApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phortune/phid/PhortuneProductPHIDType.php

@@ -12,6 +12,10 @@ final class PhortuneProductPHIDType extends PhabricatorPHIDType {
     return new PhortuneProduct();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhortuneApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phortune/phid/PhortunePurchasePHIDType.php

@@ -12,6 +12,10 @@ final class PhortunePurchasePHIDType extends PhabricatorPHIDType {
     return new PhortunePurchase();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhortuneApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phortune/phid/PhortuneSubscriptionPHIDType.php

@@ -12,6 +12,10 @@ final class PhortuneSubscriptionPHIDType extends PhabricatorPHIDType {
     return new PhortuneSubscription();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhortuneApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phragment/phid/PhragmentFragmentPHIDType.php

@@ -12,6 +12,10 @@ final class PhragmentFragmentPHIDType extends PhabricatorPHIDType {
     return new PhragmentFragment();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhragmentApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phragment/phid/PhragmentFragmentVersionPHIDType.php

@@ -12,6 +12,10 @@ final class PhragmentFragmentVersionPHIDType extends PhabricatorPHIDType {
     return new PhragmentFragmentVersion();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhragmentApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phragment/phid/PhragmentSnapshotPHIDType.php

@@ -12,6 +12,10 @@ final class PhragmentSnapshotPHIDType extends PhabricatorPHIDType {
     return new PhragmentSnapshot();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhragmentApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phriction/phid/PhrictionDocumentPHIDType.php

@@ -8,14 +8,14 @@ final class PhrictionDocumentPHIDType extends PhabricatorPHIDType {
     return pht('Phriction Wiki Document');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorPhrictionApplication';
-  }
-
   public function newObject() {
     return new PhrictionDocument();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhrictionApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/phurl/phid/PhabricatorPhurlURLPHIDType.php

@@ -8,14 +8,14 @@ final class PhabricatorPhurlURLPHIDType extends PhabricatorPHIDType {
     return pht('URL');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorPhurlApplication';
-  }
-
   public function newObject() {
     return new PhabricatorPhurlURL();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPhurlApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/policy/phid/PhabricatorPolicyPHIDTypePolicy.php

@@ -12,6 +12,10 @@ final class PhabricatorPolicyPHIDTypePolicy extends PhabricatorPHIDType {
     return new PhabricatorPolicy();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPolicyApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/ponder/phid/PonderQuestionPHIDType.php

@@ -8,14 +8,14 @@ final class PonderQuestionPHIDType extends PhabricatorPHIDType {
     return pht('Ponder Question');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorPonderApplication';
-  }
-
   public function newObject() {
     return new PonderQuestion();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorPonderApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/project/phid/PhabricatorProjectColumnPHIDType.php

@@ -8,12 +8,16 @@ final class PhabricatorProjectColumnPHIDType extends PhabricatorPHIDType {
     return pht('Project Column');
   }
 
+  public function getTypeIcon() {
+    return 'fa-columns bluegrey';
+  }
+
   public function newObject() {
     return new PhabricatorProjectColumn();
   }
 
-  public function getTypeIcon() {
-    return 'fa-columns bluegrey';
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorProjectApplication';
   }
 
   protected function buildQueryForObjects(

src/applications/project/phid/PhabricatorProjectProjectPHIDType.php

@@ -8,10 +8,6 @@ final class PhabricatorProjectProjectPHIDType extends PhabricatorPHIDType {
     return pht('Project');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorProjectApplication';
-  }
-
   public function getTypeIcon() {
     return 'fa-briefcase bluegrey';
   }
@@ -20,6 +16,10 @@ final class PhabricatorProjectProjectPHIDType extends PhabricatorPHIDType {
     return new PhabricatorProject();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorProjectApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/releeph/phid/ReleephBranchPHIDType.php

@@ -12,6 +12,10 @@ final class ReleephBranchPHIDType extends PhabricatorPHIDType {
     return new ReleephBranch();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorReleephApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/releeph/phid/ReleephProductPHIDType.php

@@ -12,6 +12,10 @@ final class ReleephProductPHIDType extends PhabricatorPHIDType {
     return new ReleephProject();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorReleephApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/releeph/phid/ReleephRequestPHIDType.php

@@ -12,6 +12,10 @@ final class ReleephRequestPHIDType extends PhabricatorPHIDType {
     return new ReleephRequest();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorReleephApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/repository/phid/PhabricatorRepositoryCommitPHIDType.php

@@ -8,14 +8,14 @@ final class PhabricatorRepositoryCommitPHIDType extends PhabricatorPHIDType {
     return pht('Diffusion Commit');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorDiffusionApplication';
-  }
-
   public function newObject() {
     return new PhabricatorRepositoryCommit();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDiffusionApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/repository/phid/PhabricatorRepositoryMirrorPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorRepositoryMirrorPHIDType extends PhabricatorPHIDType {
     return new PhabricatorRepositoryMirror();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDiffusionApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/repository/phid/PhabricatorRepositoryPushEventPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorRepositoryPushEventPHIDType extends PhabricatorPHIDType {
     return new PhabricatorRepositoryPushEvent();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDiffusionApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/repository/phid/PhabricatorRepositoryPushLogPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorRepositoryPushLogPHIDType extends PhabricatorPHIDType {
     return new PhabricatorRepositoryPushLog();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDiffusionApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/repository/phid/PhabricatorRepositoryRepositoryPHIDType.php

@@ -17,6 +17,10 @@ final class PhabricatorRepositoryRepositoryPHIDType
     return new PhabricatorRepository();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDiffusionApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/slowvote/phid/PhabricatorSlowvotePollPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorSlowvotePollPHIDType extends PhabricatorPHIDType {
     return new PhabricatorSlowvotePoll();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorSlowvoteApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/spaces/phid/PhabricatorSpacesNamespacePHIDType.php

@@ -9,14 +9,14 @@ final class PhabricatorSpacesNamespacePHIDType
     return pht('Space');
   }
 
-  public function getPHIDTypeApplicationClass() {
-    return 'PhabricatorSpacesApplication';
-  }
-
   public function newObject() {
     return new PhabricatorSpacesNamespace();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorSpacesApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/tokens/phid/PhabricatorTokenTokenPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorTokenTokenPHIDType extends PhabricatorPHIDType {
     return new PhabricatorToken();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorTokensApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/applications/transactions/phid/PhabricatorApplicationTransactionTransactionPHIDType.php

@@ -16,6 +16,10 @@ final class PhabricatorApplicationTransactionTransactionPHIDType
     return null;
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorTransactionsApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $object_query,
     array $phids) {

src/infrastructure/daemon/workers/phid/PhabricatorWorkerBulkJobPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorWorkerBulkJobPHIDType extends PhabricatorPHIDType {
     return new PhabricatorWorkerBulkJob();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDaemonsApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {

src/infrastructure/daemon/workers/phid/PhabricatorWorkerTriggerPHIDType.php

@@ -12,6 +12,10 @@ final class PhabricatorWorkerTriggerPHIDType extends PhabricatorPHIDType {
     return new PhabricatorWorkerTrigger();
   }
 
+  public function getPHIDTypeApplicationClass() {
+    return 'PhabricatorDaemonsApplication';
+  }
+
   protected function buildQueryForObjects(
     PhabricatorObjectQuery $query,
     array $phids) {