archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Don't show detailed unittest result box if all tests passed

Browse Source 
Summary:
When all unit tests pass, a box appears between the unit test results and lint
status (for test failures to go in). This checks if there's anything to put
in that div/ul before putting it on the page.

Test Plan:
Loaded a revision with unit tests OK and saw no box. Loaded a revision with
failing unittests, and saw the same box from before.

Reviewers: tuomaspelkonen, epriestley

Reviewed By: epriestley

CC: jungejason, aran, nh, epriestley

Differential Revision: https://secure.phabricator.com/D1295
This commit is contained in:
Nick Harper
2012-01-03 13:47:36 -08:00
parent 369079dd45
commit 4a77906141
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/applications/differential/field/specification/unit/DifferentialUnitFieldSpecification.php
View File

@@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -67,6 +67,8 @@ final class DifferentialUnitFieldSpecification
$postponed_count++; $postponed_count++;
} }
} }
}
if ($unit_messages) {
$utail = $utail =
'<div class="differential-unit-block">'. '<div class="differential-unit-block">'.
'<ul>'. '<ul>'.