Add Recent label to Conpherence thread list
Summary: Fix 'No Conpherences' layout, add 'Recent' label to list. Test Plan: test with and without a list of threads. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11569
This commit is contained in:
		| @@ -46,7 +46,7 @@ return array( | |||||||
|     'rsrc/css/application/config/config-welcome.css' => 'b0d16200', |     'rsrc/css/application/config/config-welcome.css' => 'b0d16200', | ||||||
|     'rsrc/css/application/config/setup-issue.css' => '8f852bc0', |     'rsrc/css/application/config/setup-issue.css' => '8f852bc0', | ||||||
|     'rsrc/css/application/config/unhandled-exception.css' => '37d4f9a2', |     'rsrc/css/application/config/unhandled-exception.css' => '37d4f9a2', | ||||||
|     'rsrc/css/application/conpherence/menu.css' => 'e1e0fdf1', |     'rsrc/css/application/conpherence/menu.css' => '73774137', | ||||||
|     'rsrc/css/application/conpherence/message-pane.css' => '684d1b80', |     'rsrc/css/application/conpherence/message-pane.css' => '684d1b80', | ||||||
|     'rsrc/css/application/conpherence/notification.css' => '04a6e10a', |     'rsrc/css/application/conpherence/notification.css' => '04a6e10a', | ||||||
|     'rsrc/css/application/conpherence/update.css' => '1099a660', |     'rsrc/css/application/conpherence/update.css' => '1099a660', | ||||||
| @@ -508,7 +508,7 @@ return array( | |||||||
|     'changeset-view-manager' => '5eb5b98c', |     'changeset-view-manager' => '5eb5b98c', | ||||||
|     'config-options-css' => '7fedf08b', |     'config-options-css' => '7fedf08b', | ||||||
|     'config-welcome-css' => 'b0d16200', |     'config-welcome-css' => 'b0d16200', | ||||||
|     'conpherence-menu-css' => 'e1e0fdf1', |     'conpherence-menu-css' => '73774137', | ||||||
|     'conpherence-message-pane-css' => '684d1b80', |     'conpherence-message-pane-css' => '684d1b80', | ||||||
|     'conpherence-notification-css' => '04a6e10a', |     'conpherence-notification-css' => '04a6e10a', | ||||||
|     'conpherence-update-css' => '1099a660', |     'conpherence-update-css' => '1099a660', | ||||||
|   | |||||||
| @@ -113,6 +113,9 @@ final class ConpherenceThreadListView extends AphrontView { | |||||||
|       $menu->addMenuItem($item); |       $menu->addMenuItem($item); | ||||||
|     } |     } | ||||||
|  |  | ||||||
|  |     $header = $this->renderMenuItemHeader(pht('Recent')); | ||||||
|  |     $menu->addMenuItem($header); | ||||||
|  |  | ||||||
|     foreach ($conpherences as $conpherence) { |     foreach ($conpherences as $conpherence) { | ||||||
|       $item = $this->renderThreadItem($conpherence); |       $item = $this->renderThreadItem($conpherence); | ||||||
|       $menu->addMenuItem($item); |       $menu->addMenuItem($item); | ||||||
| @@ -130,6 +133,13 @@ final class ConpherenceThreadListView extends AphrontView { | |||||||
|     return $menu; |     return $menu; | ||||||
|   } |   } | ||||||
|  |  | ||||||
|  |   private function renderMenuItemHeader($title) { | ||||||
|  |     $item = id(new PHUIListItemView()) | ||||||
|  |       ->setType(PHUIListItemView::TYPE_LABEL) | ||||||
|  |       ->setName($title); | ||||||
|  |     return $item; | ||||||
|  |   } | ||||||
|  |  | ||||||
|   public function getScrollMenuItem( |   public function getScrollMenuItem( | ||||||
|     ConpherenceParticipant $participant, |     ConpherenceParticipant $participant, | ||||||
|     $direction) { |     $direction) { | ||||||
| @@ -159,7 +169,7 @@ final class ConpherenceThreadListView extends AphrontView { | |||||||
|       array( |       array( | ||||||
|         'class' => 'no-conpherences-menu-item', |         'class' => 'no-conpherences-menu-item', | ||||||
|       ), |       ), | ||||||
|       pht('No conpherences.')); |       pht('No Conpherences')); | ||||||
|  |  | ||||||
|     return id(new PHUIListItemView()) |     return id(new PHUIListItemView()) | ||||||
|       ->setType(PHUIListItemView::TYPE_CUSTOM) |       ->setType(PHUIListItemView::TYPE_CUSTOM) | ||||||
|   | |||||||
| @@ -175,11 +175,13 @@ | |||||||
|   font-size: 11px; |   font-size: 11px; | ||||||
| } | } | ||||||
|  |  | ||||||
| .no-conpherences-menu-item { | .conpherence-menu-item-header { | ||||||
|   color: #a1a5a9; |   font-weight: bold; | ||||||
|   border-top: solid 1px #3B3D3E; |   text-transform: uppercase; | ||||||
|   padding: 20px 0; |   color: {$bluetext}; | ||||||
|   margin: 0px auto; | } | ||||||
|   width: 280px; |  | ||||||
|   text-align: center; | .no-conpherences-menu-item { | ||||||
|  |   color: {$bluetext}; | ||||||
|  |   padding: 4px 12px; | ||||||
| } | } | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 Chad Little
					Chad Little