archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to run

Browse Source 
Summary: Ref T10769. See PHI8. We have an unconditional logging write which we can skip in read-only mode.

Test Plan:
  - Put Phabricator in read-only mode with `cluster.read-only`.
  - Called `conduit.ping` via web UI.
    - Before: write-on-read-only exception.
    - After: good result.

Reviewers: chad, amckinley

Reviewed By: chad

Maniphest Tasks: T10769

Differential Revision: https://secure.phabricator.com/D18233
This commit is contained in:
epriestley
2017-07-18 08:49:35 -07:00
parent d1f144b214
commit 4d1ed12a9e
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/applications/conduit/controller/PhabricatorConduitAPIController.php
View File

@@ -119,9 +119,11 @@ final class PhabricatorConduitAPIController
->setError((string)$error_code) ->setError((string)$error_code)
->setDuration(1000000 * ($time_end - $time_start)); ->setDuration(1000000 * ($time_end - $time_start));
$unguarded = AphrontWriteGuard::beginScopedUnguardedWrites(); if (!PhabricatorEnv::isReadOnly()) {
$log->save(); $unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
unset($unguarded); $log->save();
unset($unguarded);
}
$response = id(new ConduitAPIResponse()) $response = id(new ConduitAPIResponse())
->setResult($result) ->setResult($result)