Clean up browse/history links in Diffusion

Summary:
Fixes T9126. In particular:

  - Add "Browse" links to all history views.
  - Use icons to show "Browse" and "History" links, instead of text.
  - Use FontAwesome.
  - Generally standardize handling of these elements.

This might need a little design attention, but I think it's an improvement overall.

Test Plan:
  - Viewed repository history.
  - Viewed branch history.
  - Viewed file history.
  - Viewed table of contents on a commit.
  - Viewed merged changes on a merge commit.
  - Viewed a directory containing an external.
  - Viewed a deleted file.

{F788419}

{F788420}

{F788421}

{F788422}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9126

Differential Revision: https://secure.phabricator.com/D14096
This commit is contained in:
epriestley
2015-09-10 19:28:49 -07:00
parent 1583738842
commit 4e181a5611
16 changed files with 186 additions and 176 deletions

View File

@@ -177,8 +177,7 @@ final class DiffusionRepositoryController extends DiffusionController {
$content[] = $this->buildHistoryTable(
$history_results,
$history,
$history_exception,
$handles);
$history_exception);
try {
$content[] = $this->buildTagListTable($drequest);
@@ -519,8 +518,7 @@ final class DiffusionRepositoryController extends DiffusionController {
private function buildHistoryTable(
$history_results,
$history,
$history_exception,
array $handles) {
$history_exception) {
$request = $this->getRequest();
$viewer = $request->getUser();
@@ -544,7 +542,6 @@ final class DiffusionRepositoryController extends DiffusionController {
$history_table = id(new DiffusionHistoryTableView())
->setUser($viewer)
->setDiffusionRequest($drequest)
->setHandles($handles)
->setHistory($history);
// TODO: Super sketchy.