Remove trivial implementations of getPagingColumn()

Summary:
Ref T7803. Some Query subclasses implement getPagingColumn() in a trivial way, usually to provide a table alias.

Formalize the concept of a primary table alias, and remove obsoleted getPagingColumn() implementations.

Test Plan: Issued affected queries.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7803

Differential Revision: https://secure.phabricator.com/D12356
This commit is contained in:
epriestley
2015-04-11 19:00:53 -07:00
parent a40c40fade
commit 4fba6e7730
8 changed files with 42 additions and 27 deletions

View File

@@ -380,8 +380,8 @@ final class PhabricatorProjectQuery
return 'PhabricatorProjectApplication';
}
protected function getApplicationSearchObjectPHIDColumn() {
return 'p.phid';
protected function getPrimaryTableAlias() {
return 'p';
}
}