Fix dead column link and provide more milestone UI context

Summary:
Fixes T10287. Ref T10286.

  - Link stuff properly.
  - Generally, show "Parent (Milestone)" instead of "Milestone".
  - This probably doesn't get 100% of `getName()` -> `getDisplayName()` swaps, but we can get those as we catch them.

Test Plan: See T10286. Also clicked stuff.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10286, T10287

Differential Revision: https://secure.phabricator.com/D15189
This commit is contained in:
epriestley
2016-02-05 12:17:35 -08:00
parent 8e7e999cc3
commit 5092bcf533
8 changed files with 33 additions and 9 deletions

View File

@@ -149,8 +149,8 @@ final class PhabricatorProjectBoardViewController
return $this->newPage()
->setTitle(
array(
$project->getDisplayName(),
pht('Workboard'),
$project->getName(),
))
->setNavigation($nav)
->setCrumbs($crumbs)
@@ -371,7 +371,11 @@ final class PhabricatorProjectBoardViewController
$crumbs->addAction($manage_menu);
return $this->newPage()
->setTitle(pht('%s Board', $project->getName()))
->setTitle(
array(
$project->getDisplayName(),
pht('Workboard'),
))
->setPageObjectPHIDs(array($project->getPHID()))
->setShowFooter(false)
->setNavigation($nav)