kill differential tabs in favor of a create diff button
Summary: kill the tabs and make it a create button instead. pertinent notes: * added a "Filter diffs" button to the form. optional, but i thought it necessary with the new green button * linked to Arcanist user guide on the create diff page. somewhat unrelated but i think create diff will get more traffic now so linking to help seemed like a reasonable add on here. Test Plan: viewed differential homepage * clicked left hand filter elements. noted "Create Diff" button on filters within user revisions and no button on filters within all revisions. * entered another user into Select User UI and viewed their diffs via button and pressing enter Reviewers: epriestley Reviewed By: epriestley CC: aran, btrahan, epriestley Differential Revision: 1157
This commit is contained in:
@@ -45,13 +45,22 @@ class DifferentialDiffCreateController extends DifferentialController {
|
||||
}
|
||||
|
||||
$form = new AphrontFormView();
|
||||
$arcanist_href = PhabricatorEnv::getDoclink(
|
||||
'article/Arcanist_User_Guide.html');
|
||||
$arcanist_link = phutil_render_tag(
|
||||
'a',
|
||||
array(
|
||||
'href' => $arcanist_href,
|
||||
'target' => '_blank',
|
||||
),
|
||||
'Arcanist');
|
||||
$form
|
||||
->setAction('/differential/diff/create/')
|
||||
->setEncType('multipart/form-data')
|
||||
->setUser($request->getUser())
|
||||
->appendChild(
|
||||
'<p class="aphront-form-instructions">The best way to create a '.
|
||||
'Differential diff is by using <strong>Arcanist</strong>, but you '.
|
||||
"Differential diff is by using $arcanist_link, but you ".
|
||||
'can also just paste a diff (e.g., from <tt>svn diff</tt> or '.
|
||||
'<tt>git diff</tt>) into this box or upload it as a file if you '.
|
||||
'really want.</p>')
|
||||
|
||||
Reference in New Issue
Block a user