archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Use window.confirm instead of confirm

Browse Source 
Summary:
This silences the following JSHint warning:

```
>>> Lint for webroot/rsrc/js/application/uiexample/notification-example.js:

   Warning  (W117) JSHintW117
    'confirm' is not defined.

              39           notification.listen(
              40             'activate',
              41             function() {
    >>>       42               if (!confirm('Close notification?')) {
              43                 JX.Stratcom.context().kill();
              44               }
              45             });

```

Test Plan: `arc lint`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11065
This commit is contained in:
Joshua Spence
2014-12-30 02:54:21 -08:00
committed by epriestley
parent 558e1ee3b8
commit 5251f08fb4
3 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
webroot/rsrc/js/application/uiexample/notification-example.js
View File

@@ -39,7 +39,7 @@ JX.behavior('phabricator-notification-example', function() {
notification.listen(
'activate',
function() {
if (!confirm('Close notification?')) {
if (!window.confirm('Close notification?')) {
JX.Stratcom.context().kill();
}
});