Mostly make the editor UI for triggers work

Summary:
Ref T5474. This provides a Herald-like UI for editing workboard trigger rules.

This probably has some missing pieces and doesn't actually save anything to the database yet, but the basics at least roughly work.

Test Plan: {F6299886}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T5474

Differential Revision: https://secure.phabricator.com/D20301
This commit is contained in:
epriestley
2019-03-21 09:32:12 -07:00
parent a5b3e33e3c
commit 567dea5449
12 changed files with 682 additions and 1 deletions

View File

@@ -65,6 +65,9 @@ final class PhabricatorProjectTriggerEditController
$v_name = $request->getStr('name');
$v_edit = $request->getStr('editPolicy');
$v_rules = $request->getStr('rules');
$v_rules = phutil_json_decode($v_rules);
$xactions = array();
if (!$trigger->getID()) {
$xactions[] = $trigger->getApplicationTransactionTemplate()
@@ -81,6 +84,8 @@ final class PhabricatorProjectTriggerEditController
->setTransactionType(PhabricatorTransactions::TYPE_EDIT_POLICY)
->setNewValue($v_edit);
// TODO: Actually write the new rules to the database.
$editor = $trigger->getApplicationTransactionEditor()
->setActor($viewer)
->setContentSourceFromRequest($request)
@@ -133,8 +138,14 @@ final class PhabricatorProjectTriggerEditController
$header = pht('New Trigger');
}
$form_id = celerity_generate_unique_node_id();
$table_id = celerity_generate_unique_node_id();
$create_id = celerity_generate_unique_node_id();
$input_id = celerity_generate_unique_node_id();
$form = id(new AphrontFormView())
->setViewer($viewer);
->setViewer($viewer)
->setID($form_id);
if ($column) {
$form->addHiddenInput('columnPHID', $column->getPHID());
@@ -161,6 +172,46 @@ final class PhabricatorProjectTriggerEditController
->setPolicies($policies)
->setError($e_edit));
$form->appendChild(
phutil_tag(
'input',
array(
'type' => 'hidden',
'name' => 'rules',
'id' => $input_id,
)));
$form->appendChild(
id(new PHUIFormInsetView())
->setTitle(pht('Rules'))
->setDescription(
pht(
'When a card is dropped into a column which uses this trigger:'))
->setRightButton(
javelin_tag(
'a',
array(
'href' => '#',
'class' => 'button button-green',
'id' => $create_id,
'mustcapture' => true,
),
pht('New Rule')))
->setContent(
javelin_tag(
'table',
array(
'id' => $table_id,
'class' => 'trigger-rules-table',
))));
$this->setupEditorBehavior(
$trigger,
$form_id,
$table_id,
$create_id,
$input_id);
$form->appendControl(
id(new AphrontFormSubmitControl())
->setValue($submit)
@@ -197,4 +248,34 @@ final class PhabricatorProjectTriggerEditController
->appendChild($column_view);
}
private function setupEditorBehavior(
PhabricatorProjectTrigger $trigger,
$form_id,
$table_id,
$create_id,
$input_id) {
$rule_list = $trigger->getTriggerRules();
$rule_list = mpull($rule_list, 'toDictionary');
$rule_list = array_values($rule_list);
$type_list = PhabricatorProjectTriggerRule::getAllTriggerRules();
$type_list = mpull($type_list, 'newTemplate');
$type_list = array_values($type_list);
require_celerity_resource('project-triggers-css');
Javelin::initBehavior(
'trigger-rule-editor',
array(
'formNodeID' => $form_id,
'tableNodeID' => $table_id,
'createNodeID' => $create_id,
'inputNodeID' => $input_id,
'rules' => $rule_list,
'types' => $type_list,
));
}
}