Improve Herald personal/global UI/UX
Summary: - Default "personal" vs "global" choice to "personal". - Don't show global rules under "My Rules". - After editing or creating a global rule, redirect back to global rule list. - Use radio buttons for "personal" vs "global" and add captions explaining the difference. - For "global" rules, don't show the owner/author in the rule detail view -- they effectively have no owner (see also D1387). - For "global" rules, don't show the owner/author in the rule list view, as above. - For admin views, show rule type (global vs personal). Test Plan: - Created and edited new global and personal rules. - Viewed "my", "global" and "admin" views. Reviewers: btrahan, jungejason, nh, xela Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1518
This commit is contained in:
@@ -0,0 +1,78 @@
|
||||
<?php
|
||||
|
||||
/*
|
||||
* Copyright 2012 Facebook, Inc.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
final class AphrontFormRadioButtonControl extends AphrontFormControl {
|
||||
|
||||
private $buttons = array();
|
||||
|
||||
public function addButton($value, $label, $caption) {
|
||||
$this->buttons[] = array(
|
||||
'value' => $value,
|
||||
'label' => $label,
|
||||
'caption' => $caption,
|
||||
);
|
||||
return $this;
|
||||
}
|
||||
|
||||
protected function getCustomControlClass() {
|
||||
return 'aphront-form-control-radio';
|
||||
}
|
||||
|
||||
protected function renderInput() {
|
||||
$rows = array();
|
||||
foreach ($this->buttons as $button) {
|
||||
$id = celerity_generate_unique_node_id();
|
||||
$radio = phutil_render_tag(
|
||||
'input',
|
||||
array(
|
||||
'id' => $id,
|
||||
'type' => 'radio',
|
||||
'name' => $this->getName(),
|
||||
'value' => $button['value'],
|
||||
'checked' => ($button['value'] == $this->getValue())
|
||||
? 'checked'
|
||||
: null,
|
||||
'disabled' => $this->getDisabled() ? 'disabled' : null,
|
||||
));
|
||||
$label = phutil_render_tag(
|
||||
'label',
|
||||
array(
|
||||
'for' => $id,
|
||||
),
|
||||
phutil_escape_html($button['label']));
|
||||
|
||||
if (strlen($button['caption'])) {
|
||||
$label .=
|
||||
'<div class="aphront-form-radio-caption">'.
|
||||
phutil_escape_html($button['caption']).
|
||||
'</div>';
|
||||
}
|
||||
$rows[] =
|
||||
'<tr>'.
|
||||
'<td>'.$radio.'</td>'.
|
||||
'<th>'.$label.'</th>'.
|
||||
'</tr>';
|
||||
}
|
||||
|
||||
return
|
||||
'<table class="aphront-form-control-radio-layout">'.
|
||||
implode("\n", $rows).
|
||||
'</table>';
|
||||
}
|
||||
|
||||
}
|
||||
15
src/view/form/control/radio/__init__.php
Normal file
15
src/view/form/control/radio/__init__.php
Normal file
@@ -0,0 +1,15 @@
|
||||
<?php
|
||||
/**
|
||||
* This file is automatically generated. Lint this module to rebuild it.
|
||||
* @generated
|
||||
*/
|
||||
|
||||
|
||||
|
||||
phutil_require_module('phabricator', 'infrastructure/celerity/api');
|
||||
phutil_require_module('phabricator', 'view/form/control/base');
|
||||
|
||||
phutil_require_module('phutil', 'markup');
|
||||
|
||||
|
||||
phutil_require_source('AphrontFormRadioButtonControl.php');
|
||||
Reference in New Issue
Block a user