Remove ManiphestTransaction

Summary: Ref T2217. The preview had the last callsite, nuke it.

Test Plan: Used preview. Grepped for `ManiphestTransaction(`, `ManiphestTransaction::`, `'ManiphestTransaction'`, `"ManiphestTransaction"`.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2217

Differential Revision: https://secure.phabricator.com/D7092

src/applications/maniphest/controller/ManiphestTransactionPreviewController.php

@@ -31,13 +31,13 @@ final class ManiphestTransactionPreviewController extends ManiphestController {
 
     $action = $request->getStr('action');
 
-    $transaction = new ManiphestTransaction();
+    $transaction = new ManiphestTransactionPro();
     $transaction->setAuthorPHID($user->getPHID());
     $transaction->setTransactionType($action);
 
     // This should really be split into a separate transaction, but it should
     // all come out in the wash once we fully move to modern stuff.
-    $transaction->getModernTransaction()->attachComment(
+    $transaction->attachComment(
       id(new ManiphestTransactionComment())
         ->setContent($comments));
 
@@ -106,18 +106,18 @@ final class ManiphestTransactionPreviewController extends ManiphestController {
 
     $engine = new PhabricatorMarkupEngine();
     $engine->setViewer($user);
-    if ($transaction->getModernTransaction()->hasComment()) {
+    if ($transaction->hasComment()) {
       $engine->addObject(
-        $transaction->getModernTransaction()->getComment(),
+        $transaction->getComment(),
         PhabricatorApplicationTransactionComment::MARKUP_FIELD_COMMENT);
     }
     $engine->process();
 
-    $transaction->getModernTransaction()->setHandles($handles);
+    $transaction->setHandles($handles);
 
     $view = id(new PhabricatorApplicationTransactionView())
       ->setUser($user)
-      ->setTransactions(mpull($transactions, 'getModernTransaction'))
+      ->setTransactions($transactions)
       ->setIsPreview(true)
       ->setIsDetailView(true);