Revert "Have DifferentialRevisionList return an ObjectBox if header is set"

This did bad things to dashboards, pulling it back until we have a more complete fix.

This reverts commit 468985c827.

Auditors: chad

src/applications/differential/controller/DifferentialRevisionViewController.php

@@ -778,7 +778,6 @@ final class DifferentialRevisionViewController extends DifferentialController {
     $user = $this->getRequest()->getUser();
 
     $view = id(new DifferentialRevisionListView())
-      ->setHeader(pht('Open Revisions Affecting These Files'))
       ->setRevisions($revisions)
       ->setUser($user);
 
@@ -786,7 +785,9 @@ final class DifferentialRevisionViewController extends DifferentialController {
     $handles = $this->loadViewerHandles($phids);
     $view->setHandles($handles);
 
-    return $view;
+    return id(new PHUIObjectBoxView())
+      ->setHeaderText(pht('Open Revisions Affecting These Files'))
+      ->appendChild($view);
   }
 
 

src/applications/differential/view/DifferentialRevisionListView.php

@@ -179,16 +179,9 @@ final class DifferentialRevisionListView extends AphrontView {
       $list->addItem($item);
     }
 
+    $list->setHeader($this->header);
     $list->setNoDataString($this->noDataString);
 
-
-    if ($this->header) {
-      $list->setFlush(true);
-      $list = id(new PHUIObjectBoxView())
-        ->setHeaderText($this->header)
-        ->appendChild($list);
-    }
-
     return $list;
   }
 

src/applications/diffusion/controller/DiffusionBrowseController.php

@@ -208,7 +208,6 @@ abstract class DiffusionBrowseController extends DiffusionController {
     }
 
     $view = id(new DifferentialRevisionListView())
-      ->setHeader(pht('Pending Differential Revisions'))
       ->setRevisions($revisions)
       ->setUser($user);
 
@@ -216,7 +215,9 @@ abstract class DiffusionBrowseController extends DiffusionController {
     $handles = $this->loadViewerHandles($phids);
     $view->setHandles($handles);
 
-    return $view;
+    return id(new PHUIObjectBoxView())
+      ->setHeaderText(pht('Pending Differential Revisions'))
+      ->appendChild($view);
   }
 
 }