Fix two issues with callsign-free repositories
Summary: Ref T4245. These callsites don't quite do the right thing if a repository has no callsign. See also <https://github.com/phacility/phabricator/pull/822>. Test Plan: Made a comment on a commit in a repository with no callsign. Reviewers: chad Reviewed By: chad Maniphest Tasks: T4245 Differential Revision: https://secure.phabricator.com/D15344
This commit is contained in:
@@ -82,9 +82,7 @@ final class PhabricatorAuditAddCommentController
|
|||||||
$draft->delete();
|
$draft->delete();
|
||||||
}
|
}
|
||||||
|
|
||||||
$monogram = $commit->getRepository()->getMonogram();
|
$uri = $commit->getURI();
|
||||||
$identifier = $commit->getCommitIdentifier();
|
|
||||||
$uri = '/'.$monogram.$identifier;
|
|
||||||
|
|
||||||
return id(new AphrontRedirectResponse())->setURI($uri);
|
return id(new AphrontRedirectResponse())->setURI($uri);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -103,7 +103,7 @@ final class DiffusionExternalController extends DiffusionController {
|
|||||||
array(
|
array(
|
||||||
'href' => $href,
|
'href' => $href,
|
||||||
),
|
),
|
||||||
$commit->getMonogram()),
|
$commit->getURI()),
|
||||||
$commit->loadCommitData()->getSummary(),
|
$commit->loadCommitData()->getSummary(),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user