Conduit -- kill tabs
Summary: this has a single side nav now. added a Utilites section below the methods which houses Logs and Token. On logs I ended up deleting this whole concept of "view" and the existing side nav -- I think there were plans to add a way to filter down to subset of the conduit calls. For logs, I envision that being a separate first class tool when / if we think we need additional complexity. On token I made the form FULL so it was like the rest of the views in this page. Test Plan: looks good! clicked on a few methods and it worked! clicked on the logs and they were there! clicked on the pager within the logs and it worked! checked out the token page and it looked good too. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Maniphest Tasks: T631 Differential Revision: https://secure.phabricator.com/D1499
This commit is contained in:
@@ -36,6 +36,7 @@ class PhabricatorConduitConsoleController
|
||||
if (empty($methods[$this->method])) {
|
||||
$this->method = key($methods);
|
||||
}
|
||||
$this->setFilter('method/'.$this->method);
|
||||
|
||||
$method_class = $methods[$this->method];
|
||||
PhutilSymbolLoader::loadClass($method_class);
|
||||
@@ -108,62 +109,13 @@ class PhabricatorConduitConsoleController
|
||||
$panel->appendChild($form);
|
||||
$panel->setWidth(AphrontPanelView::WIDTH_FULL);
|
||||
|
||||
$view = new AphrontSideNavView();
|
||||
foreach ($this->buildNavItems() as $item) {
|
||||
$view->addNavItem($item);
|
||||
}
|
||||
|
||||
$view->appendChild($panel);
|
||||
|
||||
return $this->buildStandardPageResponse(
|
||||
array($view),
|
||||
array($panel),
|
||||
array(
|
||||
'title' => 'Conduit Console',
|
||||
'tab' => 'console',
|
||||
));
|
||||
}
|
||||
|
||||
private function buildNavItems() {
|
||||
$classes = $this->getAllMethodImplementationClasses();
|
||||
$method_names = array();
|
||||
foreach ($classes as $method_class) {
|
||||
$method_name = ConduitAPIMethod::getAPIMethodNameFromClassName(
|
||||
$method_class);
|
||||
$parts = explode('.', $method_name);
|
||||
$method_names[] = array(
|
||||
'full_name' => $method_name,
|
||||
'group_name' => reset($parts),
|
||||
);
|
||||
}
|
||||
$method_names = igroup($method_names, 'group_name');
|
||||
ksort($method_names);
|
||||
|
||||
$items = array();
|
||||
foreach ($method_names as $group => $methods) {
|
||||
$items[] = phutil_render_tag(
|
||||
'a',
|
||||
array(
|
||||
),
|
||||
phutil_escape_html($group));
|
||||
foreach ($methods as $method) {
|
||||
$method_name = $method['full_name'];
|
||||
$selected = ($method_name == $this->method);
|
||||
$items[] = phutil_render_tag(
|
||||
'a',
|
||||
array(
|
||||
'class' => $selected ? 'aphront-side-nav-selected' : null,
|
||||
'href' => '/conduit/method/'.$method_name,
|
||||
),
|
||||
phutil_escape_html($method_name));
|
||||
}
|
||||
$items[] = '<hr />';
|
||||
}
|
||||
// Pop off the last '<hr />'.
|
||||
array_pop($items);
|
||||
|
||||
return $items;
|
||||
}
|
||||
|
||||
private function getAllMethods() {
|
||||
$classes = $this->getAllMethodImplementationClasses();
|
||||
$methods = array();
|
||||
@@ -173,15 +125,4 @@ class PhabricatorConduitConsoleController
|
||||
}
|
||||
return $methods;
|
||||
}
|
||||
|
||||
private function getAllMethodImplementationClasses() {
|
||||
$classes = id(new PhutilSymbolLoader())
|
||||
->setAncestorClass('ConduitAPIMethod')
|
||||
->setType('class')
|
||||
->setConcreteOnly(true)
|
||||
->selectSymbolsWithoutLoading();
|
||||
|
||||
return array_values(ipull($classes, 'name'));
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user