Don't add author and reviewers to CCs
Summary: Commenting on a diff causes adding the writer to the CCs. It doesn't make much sense if the writer is author or reviewer who get all the copies anyway. I've also moved the decision to DifferentialCommentEditor. Test Plan: Comment on a diff where I am author Comment on a diff where I am reviewer Comment on a diff where I am neither Explicitely Add CCs where I am author Reviewers: epriestley Reviewed By: epriestley CC: jungejason, aran, epriestley Differential Revision: https://secure.phabricator.com/D1397
This commit is contained in:
@@ -1,7 +1,7 @@
|
||||
<?php
|
||||
|
||||
/*
|
||||
* Copyright 2011 Facebook, Inc.
|
||||
* Copyright 2012 Facebook, Inc.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -50,7 +50,6 @@ class DifferentialCommentSaveController extends DifferentialController {
|
||||
->setMessage($comment)
|
||||
->setContentSource($content_source)
|
||||
->setAttachInlineComments(true)
|
||||
->setAddCC($action != DifferentialAction::ACTION_RESIGN)
|
||||
->setAddedReviewers($reviewers)
|
||||
->setAddedCCs($ccs)
|
||||
->save();
|
||||
|
||||
Reference in New Issue
Block a user