Show more information on revision views
Summary: Show line count, arcanist project and base revision. This adds a little clutter but I think we're still okay and I can play around with it later. Test Plan: Looked at a couple of revisions. I'm actually not 100% sure about the SVN logic but maybe I will test that before committing. Reviewed By: tomo Reviewers: tomo, jungejason, tuomaspelkonen, aran CC: aran, tomo Differential Revision: 685
This commit is contained in:
@@ -99,6 +99,10 @@ class DifferentialRevisionViewController extends DifferentialController {
|
||||
}
|
||||
}
|
||||
|
||||
if ($target->getArcanistProjectPHID()) {
|
||||
$object_phids[] = $target->getArcanistProjectPHID();
|
||||
}
|
||||
|
||||
foreach ($revision->getAttached() as $type => $phids) {
|
||||
foreach ($phids as $phid => $info) {
|
||||
$object_phids[] = $phid;
|
||||
@@ -457,6 +461,13 @@ class DifferentialRevisionViewController extends DifferentialController {
|
||||
$properties['Commits'] = implode('<br />', $links);
|
||||
}
|
||||
|
||||
$properties['Lines'] = number_format($diff->getLineCount());
|
||||
$arcanist_phid = $diff->getArcanistProjectPHID();
|
||||
if ($arcanist_phid) {
|
||||
$properties['Arcanist Project'] = phutil_escape_html(
|
||||
$handles[$arcanist_phid]->getName());
|
||||
}
|
||||
|
||||
$properties['Apply Patch'] =
|
||||
'<tt>arc patch D'.$revision->getID().'</tt>';
|
||||
$properties['Export Patch'] =
|
||||
|
||||
Reference in New Issue
Block a user