Show packages in table of contents views in Diffusion and Differential
Summary:
Fixes T8004.
- For paths which are part of a package, show the package.
- Highlight paths which are part of a package you (the viewer) have authority over.
Test Plan:
{F725418}
- Viewed owned and unowned chagnes in Diffusion and Differential.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T8004
Differential Revision: https://secure.phabricator.com/D13923
This commit is contained in:
@@ -30,6 +30,39 @@ abstract class DifferentialController extends PhabricatorController {
|
||||
$toc_view = id(new PHUIDiffTableOfContentsListView())
|
||||
->setUser($viewer);
|
||||
|
||||
$have_owners = PhabricatorApplication::isClassInstalledForViewer(
|
||||
'PhabricatorOwnersApplication',
|
||||
$viewer);
|
||||
if ($have_owners) {
|
||||
$repository_phid = null;
|
||||
if ($changesets) {
|
||||
$changeset = head($changesets);
|
||||
$diff = $changeset->getDiff();
|
||||
$repository_phid = $diff->getRepositoryPHID();
|
||||
}
|
||||
|
||||
if (!$repository_phid) {
|
||||
$have_owners = false;
|
||||
} else {
|
||||
if ($viewer->getPHID()) {
|
||||
$packages = id(new PhabricatorOwnersPackageQuery())
|
||||
->setViewer($viewer)
|
||||
->withAuthorityPHIDs(array($viewer->getPHID()))
|
||||
->execute();
|
||||
$toc_view->setAuthorityPackages($packages);
|
||||
}
|
||||
|
||||
// TODO: For Subversion, we should adjust these paths to be relative to
|
||||
// the repository root where possible.
|
||||
$paths = mpull($changesets, 'getFilename');
|
||||
|
||||
$control_query = id(new PhabricatorOwnersPackageQuery())
|
||||
->setViewer($viewer)
|
||||
->withControl($repository_phid, $paths);
|
||||
$control_query->execute();
|
||||
}
|
||||
}
|
||||
|
||||
foreach ($changesets as $changeset_id => $changeset) {
|
||||
$is_visible = isset($visible_changesets[$changeset_id]);
|
||||
$anchor = $changeset->getAnchorName();
|
||||
@@ -44,6 +77,15 @@ abstract class DifferentialController extends PhabricatorController {
|
||||
->setCoverage(idx($coverage, $filename))
|
||||
->setCoverageID($coverage_id);
|
||||
|
||||
if ($have_owners) {
|
||||
$package = $control_query->getControllingPackageForPath(
|
||||
$repository_phid,
|
||||
$changeset->getFilename());
|
||||
if ($package) {
|
||||
$item->setPackage($package);
|
||||
}
|
||||
}
|
||||
|
||||
$toc_view->addItem($item);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user