Remove dedicated "Jump Nav" navigation element
Summary: Fixes T5175. Not sure if I cleaned out everything, but this seemed like a reasonable first pass. Attempted to delete all code that belonged to Jump Nav feature only. Test Plan: Open phabricator homepage, verify Jump Nav element is gone, verify the Search bar still autocompletes and jumps to shortcuts. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Maniphest Tasks: T5175 Differential Revision: https://secure.phabricator.com/D9301
This commit is contained in:
@@ -16,10 +16,6 @@ final class PhabricatorHomeMainController
|
||||
|
||||
public function processRequest() {
|
||||
$user = $this->getRequest()->getUser();
|
||||
|
||||
if ($this->filter == 'jump') {
|
||||
return $this->buildJumpResponse();
|
||||
}
|
||||
$nav = $this->buildNav();
|
||||
|
||||
$dashboard = PhabricatorDashboardInstall::getDashboard(
|
||||
@@ -92,8 +88,6 @@ final class PhabricatorHomeMainController
|
||||
$welcome_panel = null;
|
||||
}
|
||||
|
||||
$jump_panel = $this->buildJumpPanel();
|
||||
|
||||
if ($has_differential) {
|
||||
$revision_panel = $this->buildRevisionPanel();
|
||||
} else {
|
||||
@@ -101,7 +95,6 @@ final class PhabricatorHomeMainController
|
||||
}
|
||||
|
||||
$content = array(
|
||||
$jump_panel,
|
||||
$welcome_panel,
|
||||
$unbreak_panel,
|
||||
$triage_panel,
|
||||
@@ -118,27 +111,6 @@ final class PhabricatorHomeMainController
|
||||
|
||||
}
|
||||
|
||||
private function buildJumpResponse() {
|
||||
$request = $this->getRequest();
|
||||
$jump = $request->getStr('jump');
|
||||
|
||||
$response = PhabricatorJumpNavHandler::getJumpResponse(
|
||||
$request->getUser(),
|
||||
$jump);
|
||||
|
||||
if ($response) {
|
||||
return $response;
|
||||
} else if ($request->isFormPost()) {
|
||||
$uri = new PhutilURI('/search/');
|
||||
$uri->setQueryParam('query', $jump);
|
||||
$uri->setQueryParam('search:primary', 'true');
|
||||
|
||||
return id(new AphrontRedirectResponse())->setURI((string)$uri);
|
||||
} else {
|
||||
return id(new AphrontRedirectResponse())->setURI('/');
|
||||
}
|
||||
}
|
||||
|
||||
private function buildUnbreakNowPanel() {
|
||||
$unbreak_now = PhabricatorEnv::getEnvConfig(
|
||||
'maniphest.priorities.unbreak-now');
|
||||
@@ -330,73 +302,6 @@ final class PhabricatorHomeMainController
|
||||
return $view;
|
||||
}
|
||||
|
||||
private function buildJumpPanel($query=null) {
|
||||
$request = $this->getRequest();
|
||||
$user = $request->getUser();
|
||||
|
||||
$uniq_id = celerity_generate_unique_node_id();
|
||||
|
||||
Javelin::initBehavior(
|
||||
'phabricator-autofocus',
|
||||
array(
|
||||
'id' => $uniq_id,
|
||||
));
|
||||
|
||||
require_celerity_resource('phabricator-jump-nav');
|
||||
|
||||
$doc_href = PhabricatorEnv::getDocLink('Jump Nav User Guide');
|
||||
$doc_link = phutil_tag(
|
||||
'a',
|
||||
array(
|
||||
'href' => $doc_href,
|
||||
),
|
||||
'Jump Nav User Guide');
|
||||
|
||||
$jump_input = phutil_tag(
|
||||
'input',
|
||||
array(
|
||||
'type' => 'text',
|
||||
'class' => 'phabricator-jump-nav',
|
||||
'name' => 'jump',
|
||||
'id' => $uniq_id,
|
||||
'value' => $query,
|
||||
));
|
||||
$jump_caption = phutil_tag(
|
||||
'p',
|
||||
array(
|
||||
'class' => 'phabricator-jump-nav-caption',
|
||||
),
|
||||
hsprintf(
|
||||
'Enter the name of an object like <tt>D123</tt> to quickly jump to '.
|
||||
'it. See %s or type <tt>help</tt>.',
|
||||
$doc_link));
|
||||
|
||||
$form = phabricator_form(
|
||||
$user,
|
||||
array(
|
||||
'action' => '/jump/',
|
||||
'method' => 'POST',
|
||||
'class' => 'phabricator-jump-nav-form',
|
||||
),
|
||||
array(
|
||||
$jump_input,
|
||||
$jump_caption,
|
||||
));
|
||||
|
||||
$panel = new AphrontPanelView();
|
||||
$panel->setNoBackground();
|
||||
// $panel->appendChild();
|
||||
|
||||
$list_filter = new AphrontListFilterView();
|
||||
$list_filter->appendChild($form);
|
||||
|
||||
$container = phutil_tag('div',
|
||||
array('class' => 'phabricator-jump-nav-container'),
|
||||
$list_filter);
|
||||
|
||||
return $container;
|
||||
}
|
||||
|
||||
private function renderSectionHeader($title, $href) {
|
||||
$header = phutil_tag(
|
||||
'a',
|
||||
|
||||
Reference in New Issue
Block a user