archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Don't allow "autoclose only" to be set in Mercurial

Browse Source 
Summary: We don't actually support this yet, so hide the configuration.

Test Plan: Edited branches for an hg repo.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7563
This commit is contained in:
epriestley
2013-11-11 16:26:58 -08:00
parent d4eca25774
commit 62794e4494
1 changed files with 22 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/applications/diffusion/controller/DiffusionRepositoryEditBranchesController.php
View File

@@ -22,9 +22,15 @@ final class DiffusionRepositoryEditBranchesController
return new Aphront404Response();
}
$is_git = false;
$is_hg = false;
switch ($repository->getVersionControlSystem()) {
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
$is_git = true;
break;
case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
$is_hg = true;
break;
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
throw new Exception(
@@ -64,9 +70,11 @@ final class DiffusionRepositoryEditBranchesController
->setTransactionType($type_track)
->setNewValue($v_track);
$xactions[] = id(clone $template)
->setTransactionType($type_autoclose)
->setNewValue($v_autoclose);
if (!$is_hg) {
$xactions[] = id(clone $template)
->setTransactionType($type_autoclose)
->setNewValue($v_autoclose);
}
id(new PhabricatorRepositoryEditor())
->setContinueOnNoEffect(true)
@@ -119,18 +127,22 @@ final class DiffusionRepositoryEditBranchesController
->setLabel(pht('Track Only'))
->setValue($v_track)
->setCaption(
pht('Example: %s', phutil_tag('tt', array(), 'master, develop'))))
->appendChild(
pht('Example: %s', phutil_tag('tt', array(), 'master, develop'))));
if (!$is_hg) {
$form->appendChild(
id(new AphrontFormTextControl())
->setName('autoclose')
->setLabel(pht('Autoclose Only'))
->setValue($v_autoclose)
->setCaption(
pht('Example: %s', phutil_tag('tt', array(), 'master, release'))))
->appendChild(
id(new AphrontFormSubmitControl())
->setValue(pht('Save Branches'))
->addCancelButton($edit_uri));
pht('Example: %s', phutil_tag('tt', array(), 'master, release'))));
}
$form->appendChild(
id(new AphrontFormSubmitControl())
->setValue(pht('Save Branches'))
->addCancelButton($edit_uri));
$form_box = id(new PHUIObjectBoxView())
->setHeaderText($title)