Don't allow "autoclose only" to be set in Mercurial
Summary: We don't actually support this yet, so hide the configuration. Test Plan: Edited branches for an hg repo. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7563
This commit is contained in:
@@ -22,9 +22,15 @@ final class DiffusionRepositoryEditBranchesController
|
|||||||
return new Aphront404Response();
|
return new Aphront404Response();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
$is_git = false;
|
||||||
|
$is_hg = false;
|
||||||
|
|
||||||
switch ($repository->getVersionControlSystem()) {
|
switch ($repository->getVersionControlSystem()) {
|
||||||
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
|
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
|
||||||
|
$is_git = true;
|
||||||
|
break;
|
||||||
case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
|
case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
|
||||||
|
$is_hg = true;
|
||||||
break;
|
break;
|
||||||
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
|
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
|
||||||
throw new Exception(
|
throw new Exception(
|
||||||
@@ -64,9 +70,11 @@ final class DiffusionRepositoryEditBranchesController
|
|||||||
->setTransactionType($type_track)
|
->setTransactionType($type_track)
|
||||||
->setNewValue($v_track);
|
->setNewValue($v_track);
|
||||||
|
|
||||||
$xactions[] = id(clone $template)
|
if (!$is_hg) {
|
||||||
->setTransactionType($type_autoclose)
|
$xactions[] = id(clone $template)
|
||||||
->setNewValue($v_autoclose);
|
->setTransactionType($type_autoclose)
|
||||||
|
->setNewValue($v_autoclose);
|
||||||
|
}
|
||||||
|
|
||||||
id(new PhabricatorRepositoryEditor())
|
id(new PhabricatorRepositoryEditor())
|
||||||
->setContinueOnNoEffect(true)
|
->setContinueOnNoEffect(true)
|
||||||
@@ -119,18 +127,22 @@ final class DiffusionRepositoryEditBranchesController
|
|||||||
->setLabel(pht('Track Only'))
|
->setLabel(pht('Track Only'))
|
||||||
->setValue($v_track)
|
->setValue($v_track)
|
||||||
->setCaption(
|
->setCaption(
|
||||||
pht('Example: %s', phutil_tag('tt', array(), 'master, develop'))))
|
pht('Example: %s', phutil_tag('tt', array(), 'master, develop'))));
|
||||||
->appendChild(
|
|
||||||
|
if (!$is_hg) {
|
||||||
|
$form->appendChild(
|
||||||
id(new AphrontFormTextControl())
|
id(new AphrontFormTextControl())
|
||||||
->setName('autoclose')
|
->setName('autoclose')
|
||||||
->setLabel(pht('Autoclose Only'))
|
->setLabel(pht('Autoclose Only'))
|
||||||
->setValue($v_autoclose)
|
->setValue($v_autoclose)
|
||||||
->setCaption(
|
->setCaption(
|
||||||
pht('Example: %s', phutil_tag('tt', array(), 'master, release'))))
|
pht('Example: %s', phutil_tag('tt', array(), 'master, release'))));
|
||||||
->appendChild(
|
}
|
||||||
id(new AphrontFormSubmitControl())
|
|
||||||
->setValue(pht('Save Branches'))
|
$form->appendChild(
|
||||||
->addCancelButton($edit_uri));
|
id(new AphrontFormSubmitControl())
|
||||||
|
->setValue(pht('Save Branches'))
|
||||||
|
->addCancelButton($edit_uri));
|
||||||
|
|
||||||
$form_box = id(new PHUIObjectBoxView())
|
$form_box = id(new PHUIObjectBoxView())
|
||||||
->setHeaderText($title)
|
->setHeaderText($title)
|
||||||
|
|||||||
Reference in New Issue
Block a user