archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Change fileName to filename

Browse Source 
Summary: There are lots of callsites to $changeset->getFilename() so it seemed
easier to rename getFileName() to getFilename() even if it includes database
change. Plus I think that getFilename() is better.

Test Plan:
Alter database.
Open revision.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Differential Revision: https://secure.phabricator.com/D1437
This commit is contained in:
vrana
2012-01-16 23:05:44 -08:00
parent ae0d9770a5
commit 6472dbe168
10 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/differential/controller/changesetview/DifferentialChangesetViewController.php
View File

@@ -244,7 +244,7 @@ class DifferentialChangesetViewController extends DifferentialController {
$inlines = array();
foreach ($lint as $msg) {
if ($msg['path'] != $changeset->getFileName()) {
if ($msg['path'] != $changeset->getFilename()) {
continue;
}
$inline = new DifferentialInlineComment();

2
src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php
View File

@@ -654,7 +654,7 @@ class DifferentialRevisionViewController extends DifferentialController {
$indexed_langs = array_fill_keys($langs, true);
foreach ($visible_changesets as $key => $changeset) {
$lang = $engine->getLanguageFromFilename($changeset->getFileName());
$lang = $engine->getLanguageFromFilename($changeset->getFilename());
if (isset($indexed_langs[$lang])) {
$symbol_indexes[$key] = array(
'lang' => $lang,