Remove Controller->getHandle() and Controller->loadHandles()

Summary: Ref T7689. Modernize all callsites of these methods.

Test Plan:
- Poked at dashboards.
  - Pretty sure this code is technically unreachable right now.
- Viewed commit; viewed "Audit Status".
- Viewed a fund; viewed "Payable to"; viewed "Owner".
- Viewed herald rules; viewed "Author"; viewed "Applies To".
- Viewed a Legalpad document; viewed "Contributors".
- Viewed Phame post list; viewed blog; viewed post (viewed "Blog", viewed "Blogger").
- Viewed a macro; viewed "Audio".
- Viewed a Phriction page; viewed "Last Author".
- Viewed a Ponder question; viewed "Author".
- Viewed a Ponder answer; viewed header.
  - Behavior changed very slightly here; whatevs.
- Viewed a Countdown; viewed "Author".

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7689

Differential Revision: https://secure.phabricator.com/D12210
This commit is contained in:
epriestley
2015-03-30 07:55:33 -07:00
parent 0f52fc771d
commit 64dddc76c5
19 changed files with 41 additions and 111 deletions

View File

@@ -87,19 +87,14 @@ final class FundInitiativeViewController
$owner_phid = $initiative->getOwnerPHID();
$merchant_phid = $initiative->getMerchantPHID();
$this->loadHandles(
array(
$owner_phid,
$merchant_phid,
));
$view->addProperty(
pht('Owner'),
$this->getHandle($owner_phid)->renderLink());
$viewer->renderHandle($owner_phid));
$view->addProperty(
pht('Payable to Merchant'),
$this->getHandle($merchant_phid)->renderLink());
$viewer->renderHandle($merchant_phid));
$view->addProperty(
pht('Total Funding'),