Convert all remaining old tabs to new PHUITabGroupViews

Summary: Ref T10628. This moves everything else over. I'll clean up the cruft in the next diff.

Test Plan:
- Viewed Conduit API page, toggled tabs.
- Viewed Harbormaster build, toggled tabs.
- Viewed a Drydock lease, swapped tabs.
- Viewed a Drydock resource, swapped tabs.
- Viewed mail, swapped tabs.
- Grepped for `addPropertyList(...)`, looked for any remaining calls with a second argument.
- Also checked rSAAS for any calls, but we don't have anything there that uses tabs.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10628

Differential Revision: https://secure.phabricator.com/D16207

src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php

@@ -36,13 +36,32 @@ final class PhabricatorMetaMTAMailViewController
       ->addTextCrumb(pht('Mail %d', $mail->getID()))
       ->setBorder(true);
 
+    $tab_group = id(new PHUITabGroupView())
+      ->addTab(
+        id(new PHUITabView())
+          ->setName(pht('Message'))
+          ->setKey('message')
+          ->appendChild($this->buildMessageProperties($mail)))
+      ->addTab(
+        id(new PHUITabView())
+          ->setName(pht('Headers'))
+          ->setKey('headers')
+          ->appendChild($this->buildHeaderProperties($mail)))
+      ->addTab(
+        id(new PHUITabView())
+          ->setName(pht('Delivery'))
+          ->setKey('delivery')
+          ->appendChild($this->buildDeliveryProperties($mail)))
+      ->addTab(
+        id(new PHUITabView())
+          ->setName(pht('Metadata'))
+          ->setKey('metadata')
+          ->appendChild($this->buildMetadataProperties($mail)));
+
     $object_box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Mail'))
       ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
-      ->addPropertyList($this->buildMessageProperties($mail), pht('Message'))
-      ->addPropertyList($this->buildHeaderProperties($mail), pht('Headers'))
-      ->addPropertyList($this->buildDeliveryProperties($mail), pht('Delivery'))
-      ->addPropertyList($this->buildMetadataProperties($mail), pht('Metadata'));
+      ->addTabGroup($tab_group);
 
     $view = id(new PHUITwoColumnView())
       ->setHeader($header)