PHT's for Differential.
Summary: Went through this last night, I had to remove some static vars, but didn't see that as a huge perf issue. Lint Test Plan: Tested numerous differential pages, creating a diff, commenting, editing. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4617
This commit is contained in:
@@ -42,33 +42,33 @@ final class DifferentialDiffCreateController extends DifferentialController {
|
||||
->setEncType('multipart/form-data')
|
||||
->setUser($request->getUser())
|
||||
->appendChild(
|
||||
'<p class="aphront-form-instructions">The best way to create a '.
|
||||
"Differential diff is by using $arcanist_link, but you ".
|
||||
'<p class="aphront-form-instructions">'.pht('The best way to create '.
|
||||
'a Differential diff is by using %s, but you '.
|
||||
'can also just paste a diff (e.g., from <tt>svn diff</tt> or '.
|
||||
'<tt>git diff</tt>) into this box or upload it as a file if you '.
|
||||
'really want.</p>')
|
||||
'really want.', $arcanist_link).'</p>')
|
||||
->appendChild(
|
||||
id(new AphrontFormTextAreaControl())
|
||||
->setLabel('Raw Diff')
|
||||
->setLabel(pht('Raw Diff'))
|
||||
->setName('diff')
|
||||
->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_TALL))
|
||||
->appendChild(
|
||||
id(new AphrontFormFileControl())
|
||||
->setLabel('Raw Diff from file')
|
||||
->setLabel(pht('Raw Diff from file'))
|
||||
->setName('diff-file'))
|
||||
->appendChild(
|
||||
id(new AphrontFormSubmitControl())
|
||||
->setValue("Create Diff \xC2\xBB"));
|
||||
->setValue(pht("Create Diff \xC2\xBB")));
|
||||
|
||||
$panel = new AphrontPanelView();
|
||||
$panel->setHeader('Create New Diff');
|
||||
$panel->setHeader(pht('Create New Diff'));
|
||||
$panel->appendChild($form);
|
||||
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
|
||||
|
||||
return $this->buildStandardPageResponse(
|
||||
$panel,
|
||||
array(
|
||||
'title' => 'Create Diff',
|
||||
'title' => pht('Create Diff'),
|
||||
));
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user