SQL Patch Management: SQL Changes
Summary:
Splits out the SQL changes. These are most of the changes, but primarily mechanical:
- Moved "initialize.sql" to "0000.legacy.sql" and partially reverted to an older version, such that patches 0000 + 000 + 001 + ... + 137 put us in the right state when applied sequentially.
- Removed "create database" commands from all SQL. These are handled by separate DB patches now, so we have the data to do operations like "storage databases" (list databases) and "storage destroy" (drop databases).
- Removed "phabricator_" namespace from all SQL, and replaced with "{$NAMESPACE}_" token so we can namespace databases.
- Shortened some column lengths so patches apply correctly if originally created as InnoDB; also a few similar tweaks elsewhere.
Test Plan: See D2323 for discussion and test plan.
Reviewers: edward, vrana, btrahan, jungejason
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T140, T345
Differential Revision: https://secure.phabricator.com/D2329
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
CREATE TABLE phabricator_repository.repository_auditrequest (
|
||||
CREATE TABLE {$NAMESPACE}_repository.repository_auditrequest (
|
||||
id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY,
|
||||
auditorPHID varchar(64) BINARY NOT NULL,
|
||||
commitPHID varchar(64) BINARY NOT NULL,
|
||||
@@ -8,9 +8,9 @@ CREATE TABLE phabricator_repository.repository_auditrequest (
|
||||
KEY (auditorPHID, auditStatus)
|
||||
) ENGINE=InnoDB;
|
||||
|
||||
INSERT INTO phabricator_repository.repository_auditrequest
|
||||
INSERT INTO {$NAMESPACE}_repository.repository_auditrequest
|
||||
(auditorPHID, commitPHID, auditStatus, auditReasons)
|
||||
SELECT packagePHID, commitPHID, auditStatus, auditReasons
|
||||
FROM phabricator_owners.owners_packagecommitrelationship;
|
||||
FROM {$NAMESPACE}_owners.owners_packagecommitrelationship;
|
||||
|
||||
DROP TABLE phabricator_owners.owners_packagecommitrelationship;
|
||||
DROP TABLE {$NAMESPACE}_owners.owners_packagecommitrelationship;
|
||||
|
||||
Reference in New Issue
Block a user