archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Remove AphrontPanelView from Diffusion

Browse Source 
Summary: Removes remaining AphrontPanelView calls in Diffusion for UI Consistency.

Test Plan: Tested each page except lint details, which I couldn't quite find a path to. Everything looks right.

Reviewers: epriestley, btrahan

Reviewed By: btrahan

Subscribers: Korvin, epriestley

Maniphest Tasks: T7427

Differential Revision: https://secure.phabricator.com/D12001
This commit is contained in:
Chad Little
2015-03-06 15:32:12 -08:00
parent 68fa70eacb
commit 6909e6206e
9 changed files with 40 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/applications/diffusion/controller/DiffusionCommitController.php
View File

@@ -899,9 +899,11 @@ final class DiffusionCommitController extends DiffusionController {
$caption = null;
if (count($merges) > $limit) {
$merges = array_slice($merges, 0, $limit);
$caption =
"This commit merges more than {$limit} changes. Only the first ".
"{$limit} are shown.";
$caption = new PHUIInfoView();
$caption->setSeverity(PHUIInfoView::SEVERITY_NOTICE);
$caption->appendChild(
pht('This commit merges more than %d changes. Only the first '.
'%d are shown.', $limit));
}
$history_table = new DiffusionHistoryTableView();
@@ -914,11 +916,12 @@ final class DiffusionCommitController extends DiffusionController {
$handles = $this->loadViewerHandles($phids);
$history_table->setHandles($handles);
$panel = new AphrontPanelView();
$panel->setHeader(pht('Merged Changes'));
$panel->setCaption($caption);
$panel = new PHUIObjectBoxView();
$panel->setHeaderText(pht('Merged Changes'));
$panel->appendChild($history_table);
$panel->setNoBackground();
if ($caption) {
$panel->setErrorView($caption);
}
return $panel;
}