archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Explicitly declare method/property visibility

Browse Source 
Summary: Self-explanatory.

Test Plan: `arc lint`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: hach-que, Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11278
This commit is contained in:
Joshua Spence
2015-01-12 08:18:12 +11:00
parent 9853ff2cff
commit 698b7f9ea3
10 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/differential/landing/DifferentialLandingStrategy.php
View File

@@ -10,7 +10,7 @@ abstract class DifferentialLandingStrategy {
/** /**
* @return PhabricatorActionView or null. * @return PhabricatorActionView or null.
*/ */
abstract function createMenuItem( public abstract function createMenuItem(
PhabricatorUser $viewer, PhabricatorUser $viewer,
DifferentialRevision $revision, DifferentialRevision $revision,
PhabricatorRepository $repository); PhabricatorRepository $repository);

2
src/applications/drydock/controller/DrydockController.php
View File

@@ -2,7 +2,7 @@
abstract class DrydockController extends PhabricatorController { abstract class DrydockController extends PhabricatorController {
abstract function buildSideNavView(); public abstract function buildSideNavView();
protected function buildApplicationMenu() { protected function buildApplicationMenu() {
return $this->buildSideNavView()->getMenu(); return $this->buildSideNavView()->getMenu();

2
src/applications/owners/storage/__tests__/PhabricatorOwnersPackageTestCase.php
View File

@@ -2,7 +2,7 @@
final class PhabricatorOwnersPackageTestCase extends PhabricatorTestCase { final class PhabricatorOwnersPackageTestCase extends PhabricatorTestCase {
function testFindLongestPathsPerPackage() { public function testFindLongestPathsPerPackage() {
$rows = array( $rows = array(
array('id' => 1, 'excluded' => 0, 'path' => 'src/'), array('id' => 1, 'excluded' => 0, 'path' => 'src/'),
array('id' => 1, 'excluded' => 1, 'path' => 'src/releeph/'), array('id' => 1, 'excluded' => 1, 'path' => 'src/releeph/'),

4
src/applications/phragment/controller/PhragmentController.php
View File

@@ -201,7 +201,7 @@ abstract class PhragmentController extends PhabricatorController {
->addPropertyList($properties); ->addPropertyList($properties);
} }
function renderConfigurationWarningIfRequired() { public function renderConfigurationWarningIfRequired() {
$alt = PhabricatorEnv::getEnvConfig('security.alternate-file-domain'); $alt = PhabricatorEnv::getEnvConfig('security.alternate-file-domain');
if ($alt === null) { if ($alt === null) {
return id(new AphrontErrorView()) return id(new AphrontErrorView())
@@ -225,7 +225,7 @@ abstract class PhragmentController extends PhabricatorController {
* are configured otherwise (because the Files app does not support showing * are configured otherwise (because the Files app does not support showing
* the info page to viewers who are not logged in). * the info page to viewers who are not logged in).
*/ */
function isCorrectlyConfigured() { public function isCorrectlyConfigured() {
$alt = PhabricatorEnv::getEnvConfig('security.alternate-file-domain'); $alt = PhabricatorEnv::getEnvConfig('security.alternate-file-domain');
return $alt !== null; return $alt !== null;
} }

2
src/applications/phragment/controller/PhragmentRevertController.php
View File

@@ -64,7 +64,7 @@ final class PhragmentRevertController extends PhragmentController {
return $this->createDialog($fragment, $version); return $this->createDialog($fragment, $version);
} }
function createDialog( public function createDialog(
PhragmentFragment $fragment, PhragmentFragment $fragment,
PhragmentFragmentVersion $version) { PhragmentFragmentVersion $version) {

2
src/applications/phragment/controller/PhragmentSnapshotDeleteController.php
View File

@@ -36,7 +36,7 @@ final class PhragmentSnapshotDeleteController extends PhragmentController {
return $this->createDialog(); return $this->createDialog();
} }
function createDialog() { public function createDialog() {
$request = $this->getRequest(); $request = $this->getRequest();
$viewer = $request->getUser(); $viewer = $request->getUser();

2
src/applications/phragment/controller/PhragmentSnapshotPromoteController.php
View File

@@ -162,7 +162,7 @@ final class PhragmentSnapshotPromoteController extends PhragmentController {
return $this->createDialog(); return $this->createDialog();
} }
function createDialog() { public function createDialog() {
$request = $this->getRequest(); $request = $this->getRequest();
$viewer = $request->getUser(); $viewer = $request->getUser();

2
src/infrastructure/log/PhabricatorAccessLog.php
View File

@@ -2,7 +2,7 @@
final class PhabricatorAccessLog { final class PhabricatorAccessLog {
static $log; private static $log;
public static function init() { public static function init() {
// NOTE: This currently has no effect, but some day we may reuse PHP // NOTE: This currently has no effect, but some day we may reuse PHP

2
src/infrastructure/log/PhabricatorSSHLog.php
View File

@@ -2,7 +2,7 @@
final class PhabricatorSSHLog extends Phobject { final class PhabricatorSSHLog extends Phobject {
static $log; private static $log;
public static function getLog() { public static function getLog() {
if (!self::$log) { if (!self::$log) {

4
src/infrastructure/storage/patch/PhabricatorSQLPatchList.php
View File

@@ -2,8 +2,8 @@
abstract class PhabricatorSQLPatchList { abstract class PhabricatorSQLPatchList {
abstract function getNamespace(); public abstract function getNamespace();
abstract function getPatches(); public abstract function getPatches();
/** /**
* Examine a directory for `.php` and `.sql` files and build patch * Examine a directory for `.php` and `.sql` files and build patch