Ability to add reviewers while requesting review

Summary: It makes perfect sense to add more reviewers while requesting review.

Test Plan:
Request review. Verify that Add Reviewers field shows and works.
Add some reviewer. Verify that comment preview works.
Submit. Verify that reviewers are saved and displayed.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1473
This commit is contained in:
vrana
2012-01-23 18:34:46 -08:00
parent 549146bc7c
commit 6a17de65df
5 changed files with 99 additions and 81 deletions

View File

@@ -42,7 +42,8 @@ class DifferentialCommentPreviewController extends DifferentialController {
$handles = array($author_phid);
$reviewers = $request->getStr('reviewers');
if ($action == DifferentialAction::ACTION_ADDREVIEWERS && $reviewers) {
if (($action == DifferentialAction::ACTION_ADDREVIEWERS
|| $action == DifferentialAction::ACTION_REQUEST) && $reviewers) {
$reviewers = explode(',', $reviewers);
$comment->setMetadata(array(
DifferentialComment::METADATA_ADDED_REVIEWERS => $reviewers));