Transactions - adding willRenderTimeline to handle tricky cases
Summary: Fixes T6693. Test Plan: Made a bunch of comments on a diff with differential, being sure to leave inlines here and there. This reproduced the issue in T6693. With this patch this issue no longer reproduces! Successfully "showed older changes" in Maniphest too. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6693 Differential Revision: https://secure.phabricator.com/D10931
This commit is contained in:
@@ -529,7 +529,8 @@ abstract class PhabricatorController extends AphrontController {
|
||||
protected function buildTransactionTimeline(
|
||||
PhabricatorApplicationTransactionInterface $object,
|
||||
PhabricatorApplicationTransactionQuery $query,
|
||||
PhabricatorMarkupEngine $engine = null) {
|
||||
PhabricatorMarkupEngine $engine = null,
|
||||
$render_data = array()) {
|
||||
|
||||
$viewer = $this->getRequest()->getUser();
|
||||
$xaction = $object->getApplicationTransactionTemplate();
|
||||
@@ -564,7 +565,9 @@ abstract class PhabricatorController extends AphrontController {
|
||||
->setUser($viewer)
|
||||
->setObjectPHID($object->getPHID())
|
||||
->setTransactions($xactions)
|
||||
->setPager($pager);
|
||||
->setPager($pager)
|
||||
->setRenderData($render_data);
|
||||
$object->willRenderTimeline($timeline, $this->getRequest());
|
||||
|
||||
return $timeline;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user