Transactions - adding willRenderTimeline to handle tricky cases

Summary: Fixes T6693.

Test Plan:
Made a bunch of comments on a diff with differential, being sure to leave inlines here and there. This reproduced the issue in T6693. With this patch this issue no longer reproduces!

Successfully "showed older changes" in Maniphest too.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6693

Differential Revision: https://secure.phabricator.com/D10931
This commit is contained in:
Bob Trahan
2014-12-04 13:58:52 -08:00
parent 20035fe9a8
commit 6ab3f06b6e
48 changed files with 373 additions and 19 deletions

View File

@@ -928,12 +928,12 @@ final class DifferentialRevisionViewController extends DifferentialController {
$timeline = $this->buildTransactionTimeline(
$revision,
new DifferentialTransactionQuery());
$timeline
->setChangesets($changesets)
->setRevision($revision)
->setLeftDiff($left_diff)
->setRightDiff($right_diff);
new DifferentialTransactionQuery(),
$engine = null,
array(
'left' => $left_diff->getID(),
'right' => $right_diff->getID(),
));
return $timeline;
}