archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix quicksand interaction with HTTP GET prefilling in ApplicationSearch

Browse Source 
Summary:
Fixes T10196. This is a weird interaction and this might not be the best long-term fix, but just get it working OK for now.

General problem is that Quicksand doesn't currently use GET for requests. This is a very unusual case where the method is relevant. In the future, I might change Quicksand to use GET.

Test Plan: Clicked "Open Tasks" with Quicksand active, got a results list.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10196

Differential Revision: https://secure.phabricator.com/D15082
This commit is contained in:
epriestley
2016-01-21 16:21:48 -08:00
parent 5f170847ca
commit 6ea9aa39a0
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/search/controller/PhabricatorApplicationSearchController.php
View File

@@ -100,7 +100,7 @@ final class PhabricatorApplicationSearchController
} else if (!strlen($this->queryKey)) { } else if (!strlen($this->queryKey)) {
$found_query_data = false; $found_query_data = false;
if ($request->isHTTPGet()) { if ($request->isHTTPGet() || $request->isQuicksand()) {
// If this is a GET request and it has some query data, don't // If this is a GET request and it has some query data, don't
// do anything unless it's only before= or after=. We'll build and // do anything unless it's only before= or after=. We'll build and
// execute a query from it below. This allows external tools to build // execute a query from it below. This allows external tools to build