archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Allow setting of button colors in headers

Browse Source 
Summary: We currently override button color for headers, since the default is blue, but if a developer sets a specific color, we should respect that.

Test Plan: Set a button in the header to green and see green. See grey everywhere else.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17922
This commit is contained in:
Chad Little
2017-05-16 20:13:34 -07:00
parent 422eb9db83
commit 6ecd6980a1
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/view/phui/PHUIButtonView.php
View File

@@ -64,6 +64,10 @@ final class PHUIButtonView extends AphrontTagView {
return $this; return $this;
} }
public function getColor() {
return $this->color;
}
public function setDisabled($disabled) { public function setDisabled($disabled) {
$this->disabled = $disabled; $this->disabled = $disabled;
return $this; return $this;

4
src/view/phui/PHUIHeaderView.php
View File

@@ -267,7 +267,9 @@ final class PHUIHeaderView extends AphrontTagView {
if ($this->actionLinks) { if ($this->actionLinks) {
$actions = array(); $actions = array();
foreach ($this->actionLinks as $button) { foreach ($this->actionLinks as $button) {
$button->setColor(PHUIButtonView::GREY); if (!$button->getColor()) {
$button->setColor(PHUIButtonView::GREY);
}
$button->addClass(PHUI::MARGIN_SMALL_LEFT); $button->addClass(PHUI::MARGIN_SMALL_LEFT);
$button->addClass('phui-header-action-link'); $button->addClass('phui-header-action-link');
$actions[] = $button; $actions[] = $button;