archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Clean up an old transaction state flag

Browse Source 
Summary: Depends on D19289. Ref T13110. This flag has been obsolete for some time and has no callers.

Test Plan: Grepped for `hasReviewTransaction`, no hits.

Maniphest Tasks: T13110

Differential Revision: https://secure.phabricator.com/D19290
This commit is contained in:
epriestley
2018-04-03 09:59:04 -07:00
parent 804f9817c3
commit 6f520e0534
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/applications/differential/editor/DifferentialTransactionEditor.php
View File

@@ -7,7 +7,6 @@ final class DifferentialTransactionEditor
private $isCloseByCommit; private $isCloseByCommit;
private $repositoryPHIDOverride = false; private $repositoryPHIDOverride = false;
private $didExpandInlineState = false; private $didExpandInlineState = false;
private $hasReviewTransaction = false;
private $affectedPaths; private $affectedPaths;
private $firstBroadcast = false; private $firstBroadcast = false;
private $wasBroadcasting; private $wasBroadcasting;
@@ -128,13 +127,6 @@ final class DifferentialTransactionEditor
// built it for us so we don't need to expand it again. // built it for us so we don't need to expand it again.
$this->didExpandInlineState = true; $this->didExpandInlineState = true;
break; break;
case DifferentialRevisionAcceptTransaction::TRANSACTIONTYPE:
case DifferentialRevisionRejectTransaction::TRANSACTIONTYPE:
case DifferentialRevisionResignTransaction::TRANSACTIONTYPE:
// If we have a review transaction, we'll skip marking the user
// as "Commented" later. This should get cleaner after T10967.
$this->hasReviewTransaction = true;
break;
case DifferentialRevisionPlanChangesTransaction::TRANSACTIONTYPE: case DifferentialRevisionPlanChangesTransaction::TRANSACTIONTYPE:
if ($xaction->getMetadataValue('draft.demote')) { if ($xaction->getMetadataValue('draft.demote')) {
$this->isDraftDemotion = true; $this->isDraftDemotion = true;