Clean up an old transaction state flag
Summary: Depends on D19289. Ref T13110. This flag has been obsolete for some time and has no callers. Test Plan: Grepped for `hasReviewTransaction`, no hits. Maniphest Tasks: T13110 Differential Revision: https://secure.phabricator.com/D19290
This commit is contained in:
@@ -7,7 +7,6 @@ final class DifferentialTransactionEditor
|
||||
private $isCloseByCommit;
|
||||
private $repositoryPHIDOverride = false;
|
||||
private $didExpandInlineState = false;
|
||||
private $hasReviewTransaction = false;
|
||||
private $affectedPaths;
|
||||
private $firstBroadcast = false;
|
||||
private $wasBroadcasting;
|
||||
@@ -128,13 +127,6 @@ final class DifferentialTransactionEditor
|
||||
// built it for us so we don't need to expand it again.
|
||||
$this->didExpandInlineState = true;
|
||||
break;
|
||||
case DifferentialRevisionAcceptTransaction::TRANSACTIONTYPE:
|
||||
case DifferentialRevisionRejectTransaction::TRANSACTIONTYPE:
|
||||
case DifferentialRevisionResignTransaction::TRANSACTIONTYPE:
|
||||
// If we have a review transaction, we'll skip marking the user
|
||||
// as "Commented" later. This should get cleaner after T10967.
|
||||
$this->hasReviewTransaction = true;
|
||||
break;
|
||||
case DifferentialRevisionPlanChangesTransaction::TRANSACTIONTYPE:
|
||||
if ($xaction->getMetadataValue('draft.demote')) {
|
||||
$this->isDraftDemotion = true;
|
||||
|
||||
Reference in New Issue
Block a user