Add ApplicationTransactions/CustomField based user profile editor

Summary: Adds a profile edit controller (with just one field and on links to it) that uses ApplicationTransactions and CustomField. {F45617} My plan is to move the other profile fields to this interface and get rid of Settings -> Profile. Basically, these will be "settings": - Sex - Language - Timezone These will be "profile": - Real Name - Title - Blurb - Profile Image (but I'm going to put this on a separate UI) - Other custom fields Test Plan: Edited my realname using the new interface. Reviewers: chad, seporaitis Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6152
2013-06-07 09:55:55 -07:00
parent 7598330e24
commit 6ffbee115b
14 changed files with 392 additions and 23 deletions
--- a/src/applications/people/controller/PhabricatorPeopleProfileEditController.php
+++ b/src/applications/people/controller/PhabricatorPeopleProfileEditController.php
@@ -0,0 +1,94 @@
+<?php
+
+final class PhabricatorPeopleProfileEditController
+  extends PhabricatorPeopleController {
+
+  private $id;
+
+  public function shouldRequireAdmin() {
+    return false;
+  }
+
+  public function willProcessRequest(array $data) {
+    $this->id = $data['id'];
+  }
+
+  public function processRequest() {
+    $request = $this->getRequest();
+    $viewer = $request->getUser();
+
+    $user = id(new PhabricatorPeopleQuery())
+      ->setViewer($viewer)
+      ->withIDs(array($this->id))
+      ->requireCapabilities(
+        array(
+          PhabricatorPolicyCapability::CAN_VIEW,
+          PhabricatorPolicyCapability::CAN_EDIT,
+        ))
+      ->executeOne();
+    if (!$user) {
+      return new Aphront404Response();
+    }
+
+    $profile_uri = '/p/'.$user->getUsername().'/';
+
+    $fields = PhabricatorCustomField::getObjectFields(
+      $user,
+      PhabricatorUserCustomFieldInterface::ROLE_EDIT);
+
+    if ($request->isFormPost()) {
+      $xactions = array();
+      foreach ($fields as $field) {
+        $field->setValueFromRequest($request);
+        $xactions[] = id(new PhabricatorUserTransaction())
+          ->setTransactionType(PhabricatorTransactions::TYPE_CUSTOMFIELD)
+          ->setMetadataValue('customfield:key', $field->getFieldKey())
+          ->setNewValue($field->getNewValueForApplicationTransactions());
+      }
+
+      $editor = id(new PhabricatorUserProfileEditor())
+        ->setActor($viewer)
+        ->setContentSource(
+          PhabricatorContentSource::newFromRequest($request))
+        ->setContinueOnNoEffect(true);
+
+      $editor->applyTransactions($user, $xactions);
+
+      return id(new AphrontRedirectResponse())->setURI($profile_uri);
+    }
+
+    $title = pht('Edit Profile');
+    $crumbs = $this->buildApplicationCrumbs();
+    $crumbs->addCrumb(
+      id(new PhabricatorCrumbView())
+        ->setName($user->getUsername())
+        ->setHref($profile_uri));
+    $crumbs->addCrumb(
+      id(new PhabricatorCrumbView())
+        ->setName($title));
+
+    $form = id(new AphrontFormView())
+      ->setUser($viewer);
+
+    foreach ($fields as $field) {
+      $form->appendChild($field->renderEditControl());
+    }
+
+    $form
+      ->appendChild(
+        id(new AphrontFormSubmitControl())
+          ->addCancelButton($profile_uri)
+          ->setValue(pht('Save Profile')));
+
+    return $this->buildApplicationPage(
+      array(
+        $crumbs,
+        $form,
+      ),
+      array(
+        'title' => $title,
+        'device' => true,
+        'dust' => true,
+      ));
+  }
+}