Fix a mail stamp issue with blocking reviewers
Summary: Revisions with blocking reviewers had this stamp built incorrectly, which cascaded into trying to use `array()` as a PHID. Recover so these tasks succeed. Test Plan: Will deploy production. Differential Revision: https://secure.phabricator.com/D19082
This commit is contained in:
		| @@ -53,7 +53,7 @@ final class DifferentialMailEngineExtension | |||||||
|       } else { |       } else { | ||||||
|         $reviewers[] = $reviewer_phid; |         $reviewers[] = $reviewer_phid; | ||||||
|         if ($reviewer->isBlocking()) { |         if ($reviewer->isBlocking()) { | ||||||
|           $reviewers[] = $blocking; |           $blocking[] = $reviewer_phid; | ||||||
|         } |         } | ||||||
|       } |       } | ||||||
|     } |     } | ||||||
|   | |||||||
| @@ -15,6 +15,15 @@ final class PhabricatorPHIDMailStamp | |||||||
|       return null; |       return null; | ||||||
|     } |     } | ||||||
|  |  | ||||||
|  |     // TODO: This recovers from a bug where blocking reviewers were serialized | ||||||
|  |     // incorrectly into the flat mail stamp list in the worker queue as arrays. | ||||||
|  |     // It can be removed some time after February 2018. | ||||||
|  |     foreach ($value as $key => $v) { | ||||||
|  |       if (is_array($v)) { | ||||||
|  |         unset($value[$key]); | ||||||
|  |       } | ||||||
|  |     } | ||||||
|  |  | ||||||
|     $viewer = $this->getViewer(); |     $viewer = $this->getViewer(); | ||||||
|     $handles = $viewer->loadHandles($value); |     $handles = $viewer->loadHandles($value); | ||||||
|  |  | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 epriestley
					epriestley