archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix some minor UI issues with mobile application search

Browse Source 
Summary: Background is now always white, spacing in header is more consistent

Test Plan: test mobile, table, desktop application search apps.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D16691
This commit is contained in:
Chad Little
2016-10-11 15:37:46 -07:00
parent 13b4b37d30
commit 754397c4e7
3 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
resources/celerity/map.php
View File

@@ -9,7 +9,7 @@ return array(
'names' => array( 'names' => array(
'conpherence.pkg.css' => '4601645d', 'conpherence.pkg.css' => '4601645d',
'conpherence.pkg.js' => '11f3e07e', 'conpherence.pkg.js' => '11f3e07e',
'core.pkg.css' => 'b8364d01', 'core.pkg.css' => '7ca260a3',
'core.pkg.js' => '30185d95', 'core.pkg.js' => '30185d95',
'darkconsole.pkg.js' => 'e7393ebb', 'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => 'e1d704ce', 'differential.pkg.css' => 'e1d704ce',
@@ -102,7 +102,7 @@ return array(
'rsrc/css/application/releeph/releeph-preview-branch.css' => 'b7a6f4a5', 'rsrc/css/application/releeph/releeph-preview-branch.css' => 'b7a6f4a5',
'rsrc/css/application/releeph/releeph-request-differential-create-dialog.css' => '8d8b92cd', 'rsrc/css/application/releeph/releeph-request-differential-create-dialog.css' => '8d8b92cd',
'rsrc/css/application/releeph/releeph-request-typeahead.css' => '667a48ae', 'rsrc/css/application/releeph/releeph-request-typeahead.css' => '667a48ae',
'rsrc/css/application/search/application-search-view.css' => 'be6454ec', 'rsrc/css/application/search/application-search-view.css' => '8452c849',
'rsrc/css/application/search/search-results.css' => '7dea472c', 'rsrc/css/application/search/search-results.css' => '7dea472c',
'rsrc/css/application/slowvote/slowvote.css' => 'a94b7230', 'rsrc/css/application/slowvote/slowvote.css' => 'a94b7230',
'rsrc/css/application/tokens/tokens.css' => '3d0f239e', 'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
@@ -610,7 +610,7 @@ return array(
'aphront-tokenizer-control-css' => '056da01b', 'aphront-tokenizer-control-css' => '056da01b',
'aphront-tooltip-css' => '1a07aea8', 'aphront-tooltip-css' => '1a07aea8',
'aphront-typeahead-control-css' => 'd4f16145', 'aphront-typeahead-control-css' => 'd4f16145',
'application-search-view-css' => 'be6454ec', 'application-search-view-css' => '8452c849',
'auth-css' => '0877ed6e', 'auth-css' => '0877ed6e',
'bulk-job-css' => 'df9c1d4a', 'bulk-job-css' => 'df9c1d4a',
'changeset-view-manager' => 'a2828756', 'changeset-view-manager' => 'a2828756',

2
src/applications/search/controller/PhabricatorApplicationSearchController.php
View File

@@ -329,7 +329,6 @@ final class PhabricatorApplicationSearchController
$crumbs->addTextCrumb($title); $crumbs->addTextCrumb($title);
} }
$nav->addClass('application-search-view');
require_celerity_resource('application-search-view-css'); require_celerity_resource('application-search-view-css');
return $this->newPage() return $this->newPage()
@@ -337,6 +336,7 @@ final class PhabricatorApplicationSearchController
->setTitle(pht('Query: %s', $title)) ->setTitle(pht('Query: %s', $title))
->setCrumbs($crumbs) ->setCrumbs($crumbs)
->setNavigation($nav) ->setNavigation($nav)
->addClass('application-search-view')
->appendChild($body); ->appendChild($body);
} }

10
webroot/rsrc/css/application/search/application-search-view.css
View File

@@ -11,6 +11,11 @@
padding: 0 16px 24px; padding: 0 16px 24px;
} }
.device-phone .application-search-view
.application-search-results.phui-object-box {
padding: 0 12px 24px;
}
.application-search-view .application-search-results .phui-profile-header { .application-search-view .application-search-results .phui-profile-header {
padding: 16px 8px; padding: 16px 8px;
border-bottom: 1px solid {$thinblueborder}; border-bottom: 1px solid {$thinblueborder};
@@ -31,6 +36,11 @@
padding: 12px 0; padding: 12px 0;
} }
.device-phone .application-search-results
.phui-profile-header.phui-header-shell {
padding: 12px 0 12px 4px;
}
.device-phone .application-search-results .device-phone .application-search-results
.phui-profile-header.phui-header-shell .phui-header-header { .phui-profile-header.phui-header-shell .phui-header-header {
font-size: 16px; font-size: 16px;