Fix an issue where scrolling down, then up, then down fails to show changeset header in Differential

Summary: Ref T13151. See PHI616. There's a bug where the current banner changeset isn't cleared correctly when we hide the banner.

Test Plan:
  - View revision with several changesets.
  - Scroll down slowly through first changeset until banner appears.
  - Scroll up until banner disappears.
  - Scroll back down.
  - Before: banner fails to reappear (code still thinks it's visible and we don't want to update it).
  - After: banner reappears correctly.

Reviewers: amckinley, jmeador

Reviewed By: jmeador

Maniphest Tasks: T13151

Differential Revision: https://secure.phabricator.com/D19474
This commit is contained in:
epriestley
2018-06-07 09:43:59 -07:00
parent b8b2d1672d
commit 7729c51cc4
2 changed files with 8 additions and 7 deletions

View File

@@ -1381,6 +1381,7 @@ JX.install('DiffChangesetList', {
var changeset = this._getVisibleChangeset();
if (!changeset) {
this._bannerChangeset = null;
JX.DOM.remove(node);
return;
}