archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Use --master-data, not --dump-slave, in bin/storage dump

Browse Source 
Summary: These flags do slightly different things, I actually want --master-data here. My test databases are setup half-weird and work with either statement, which is why I missed this.

Test Plan: Ran a dump against master, got the right CHANGE MASTER statement with no warnings.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15716
This commit is contained in:
epriestley
2016-04-14 14:50:52 -07:00
parent bbb321395a
commit 7852ec1619
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/docs/user/cluster/cluster_databases.diviner
View File

@@ -302,7 +302,7 @@ this command //from// that host, to avoid sending the whole dump over the
network). network).
With the `--for-replica` flag, the `bin/storage dump` command creates dumps With the `--for-replica` flag, the `bin/storage dump` command creates dumps
with `--dump-slave`, which includes a `CHANGE MASTER` statement in the output. with `--master-data`, which includes a `CHANGE MASTER` statement in the output.
This may be helpful when initially setting up new replicas, as it can make it This may be helpful when initially setting up new replicas, as it can make it
easier to change the binlog coordinates to the correct position for the dump. easier to change the binlog coordinates to the correct position for the dump.

4
src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php
View File

@@ -13,7 +13,7 @@ final class PhabricatorStorageManagementDumpWorkflow
array( array(
'name' => 'for-replica', 'name' => 'for-replica',
'help' => pht( 'help' => pht(
'Add __--dump-slave__ to the __mysqldump__ command, '. 'Add __--master-data__ to the __mysqldump__ command, '.
'generating a CHANGE MASTER statement in the output.'), 'generating a CHANGE MASTER statement in the output.'),
), ),
)); ));
@@ -57,7 +57,7 @@ final class PhabricatorStorageManagementDumpWorkflow
$argv[] = '--default-character-set=utf8'; $argv[] = '--default-character-set=utf8';
if ($args->getArg('for-replica')) { if ($args->getArg('for-replica')) {
$argv[] = '--dump-slave'; $argv[] = '--master-data';
} }
$argv[] = '-u'; $argv[] = '-u';