Make editing project images redirect to "Manage" more consistently
Summary: Ref T12732. Currently, different ways of setting a profile image can leave you in different places. Instead, always send the user back to the "Manage" page. Test Plan: Used "Current Picture", "use picture", "Build picture" and "upload picture", always ended up in the same spot. Reviewers: chad, amckinley Reviewed By: amckinley Maniphest Tasks: T12732 Differential Revision: https://secure.phabricator.com/D17967
This commit is contained in:
@@ -23,8 +23,7 @@ final class PhabricatorProjectEditPictureController
|
||||
|
||||
$this->setProject($project);
|
||||
|
||||
$edit_uri = $this->getApplicationURI('profile/'.$project->getID().'/');
|
||||
$view_uri = $this->getApplicationURI('profile/'.$project->getID().'/');
|
||||
$manage_uri = $this->getApplicationURI('manage/'.$project->getID().'/');
|
||||
|
||||
$supported_formats = PhabricatorFile::getTransformableImageFormats();
|
||||
$e_file = true;
|
||||
@@ -90,7 +89,7 @@ final class PhabricatorProjectEditPictureController
|
||||
|
||||
$editor->applyTransactions($project, $xactions);
|
||||
|
||||
return id(new AphrontRedirectResponse())->setURI($edit_uri);
|
||||
return id(new AphrontRedirectResponse())->setURI($manage_uri);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -243,7 +242,7 @@ final class PhabricatorProjectEditPictureController
|
||||
pht('Supported formats: %s', implode(', ', $supported_formats))))
|
||||
->appendChild(
|
||||
id(new AphrontFormSubmitControl())
|
||||
->addCancelButton($edit_uri)
|
||||
->addCancelButton($manage_uri)
|
||||
->setValue(pht('Upload Picture')));
|
||||
|
||||
$form_box = id(new PHUIObjectBoxView())
|
||||
|
||||
Reference in New Issue
Block a user