Move a bunch more rendering into SearchEngine
Summary: Ref T4986. These are mostly mechanical now, I skipped a couple of slightly tricky ones. Still a bunch to go. Test Plan: For each engine: - Viewed the application; - created a panel to issue the query. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4986 Differential Revision: https://secure.phabricator.com/D9017
This commit is contained in:
@@ -1,7 +1,6 @@
|
||||
<?php
|
||||
|
||||
final class DifferentialRevisionListController extends DifferentialController
|
||||
implements PhabricatorApplicationSearchResultsControllerInterface {
|
||||
final class DifferentialRevisionListController extends DifferentialController {
|
||||
|
||||
private $queryKey;
|
||||
|
||||
@@ -23,64 +22,4 @@ final class DifferentialRevisionListController extends DifferentialController
|
||||
return $this->delegateToController($controller);
|
||||
}
|
||||
|
||||
public function renderResultsList(
|
||||
array $revisions,
|
||||
PhabricatorSavedQuery $query) {
|
||||
assert_instances_of($revisions, 'DifferentialRevision');
|
||||
|
||||
$user = $this->getRequest()->getUser();
|
||||
$template = id(new DifferentialRevisionListView())
|
||||
->setUser($user);
|
||||
|
||||
$views = array();
|
||||
if ($query->getQueryKey() == 'active') {
|
||||
$split = DifferentialRevisionQuery::splitResponsible(
|
||||
$revisions,
|
||||
$query->getParameter('responsiblePHIDs'));
|
||||
list($blocking, $active, $waiting) = $split;
|
||||
|
||||
$views[] = id(clone $template)
|
||||
->setHeader(pht('Blocking Others'))
|
||||
->setNoDataString(
|
||||
pht('No revisions are blocked on your action.'))
|
||||
->setHighlightAge(true)
|
||||
->setRevisions($blocking)
|
||||
->setHandles(array());
|
||||
|
||||
$views[] = id(clone $template)
|
||||
->setHeader(pht('Action Required'))
|
||||
->setNoDataString(
|
||||
pht('No revisions require your action.'))
|
||||
->setHighlightAge(true)
|
||||
->setRevisions($active)
|
||||
->setHandles(array());
|
||||
|
||||
$views[] = id(clone $template)
|
||||
->setHeader(pht('Waiting on Others'))
|
||||
->setNoDataString(
|
||||
pht('You have no revisions waiting on others.'))
|
||||
->setRevisions($waiting)
|
||||
->setHandles(array());
|
||||
} else {
|
||||
$views[] = id(clone $template)
|
||||
->setRevisions($revisions)
|
||||
->setHandles(array());
|
||||
}
|
||||
|
||||
$phids = array_mergev(mpull($views, 'getRequiredHandlePHIDs'));
|
||||
$handles = $this->loadViewerHandles($phids);
|
||||
|
||||
foreach ($views as $view) {
|
||||
$view->setHandles($handles);
|
||||
}
|
||||
|
||||
if (count($views) == 1) {
|
||||
// Reduce this to a PHUIObjectItemListView so we can get the free
|
||||
// support from ApplicationSearch.
|
||||
return head($views)->render();
|
||||
} else {
|
||||
return $views;
|
||||
}
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user