Sort out application crumbs in new repository edit workflow

Summary: Ref T2231. Crumbs in the Diffusion edit workflow are a bit wonky, with stuff like "rP (master)" which isn't very useful and no link back to the main "Edit" page. Make them consistent across all the screens.

Test Plan: Loaded a bunch of these screens and saw sane crumbs on all of them.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2231

Differential Revision: https://secure.phabricator.com/D7407
This commit is contained in:
epriestley
2013-10-25 15:58:58 -07:00
parent 1975bdfb36
commit 796db9f9c6
12 changed files with 494 additions and 465 deletions

View File

@@ -1,6 +1,7 @@
<?php
final class DiffusionRepositoryEditBasicController extends DiffusionController {
final class DiffusionRepositoryEditBasicController
extends DiffusionRepositoryEditController {
public function processRequest() {
$request = $this->getRequest();
@@ -65,7 +66,7 @@ final class DiffusionRepositoryEditBasicController extends DiffusionController {
}
}
$crumbs = $this->buildCrumbs();
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Edit Basics')));