Phriction Redesign

Summary: This is mostly minor, but visually it makes the wiki feel more 'page like' and better separates the actual content from other data displayed.

Test Plan: Tested Chrome, iPhone, and iPad.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin, AnhNhan

Maniphest Tasks: T2686

Differential Revision: https://secure.phabricator.com/D5366

src/applications/phriction/controller/PhrictionDocumentController.php

@@ -30,6 +30,9 @@ final class PhrictionDocumentController
       $slug);
 
     $version_note = null;
+    $core_content = '';
+    $byline = '';
+    $move_notice = '';
 
     if (!$document) {
 
@@ -211,11 +214,6 @@ final class PhrictionDocumentController
           ->render();
       }
 
-      $page_content = hsprintf(
-        '<div class="phriction-content">%s%s%s</div>',
-        $byline,
-        $move_notice,
-        $core_content);
     }
 
     if ($version_note) {
@@ -236,18 +234,38 @@ final class PhrictionDocumentController
     $header = id(new PhabricatorHeaderView())
       ->setHeader($page_title);
 
+      $page_content = hsprintf(
+        '<div class="phriction-wrap">
+          <div class="phriction-content">
+            %s%s%s%s%s
+          </div>
+          <div class="phriction-fake-space"></div>
+        </div>',
+        $header,
+        $actions,
+        $byline,
+        $move_notice,
+        $core_content);
+
+    $core_page = phutil_tag(
+      'div',
+        array(
+          'class' => 'phriction-offset'
+        ),
+        array(
+          $page_content,
+          $children,
+        ));
+
     return $this->buildApplicationPage(
       array(
         $crumbs->render(),
-        $header->render(),
-        $actions->render(),
-        $version_note,
-        $page_content,
-        $children,
+        $core_page,
       ),
       array(
         'title'   => $page_title,
         'device'  => true,
+        'dust'    => true,
       ));
 
   }
@@ -411,10 +429,12 @@ final class PhrictionDocumentController
     }
 
     return hsprintf(
-      '<div class="phriction-children">'.
-        '<div class="phriction-children-header">%s</div>'.
-        '%s'.
-      '</div>',
+      '<div class="phriction-wrap">
+        <div class="phriction-children">
+        <div class="phriction-children-header">%s</div>
+        %s
+        </div>
+      </div>',
       pht('Document Hierarchy'),
       phutil_tag('ul', array(), $list));
   }