Add very basic UI for creating milestones and subprojects

Summary: Ref T10010. This has a lot of UI/UX problems but I think it: - technically allows subproject creation; - technically allows milestone creation; - doesn't let users unwittingly destroy their installs (probably). Test Plan: - Created milestones. - Created subprojects. - Created and edited normal projects. - Observed some reasonable interactions (e.g., you can't create milestones for a milestone or edit a superproject's members). - Observed plenty of silly/confusing interactions that need additional work. {F1046657} {F1046658} {F1046655} {F1046656} {F1046654} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10010 Differential Revision: https://secure.phabricator.com/D14904
2015-12-27 05:16:36 -08:00
parent 7732f9c03c
commit 7c5ad63fd1
14 changed files with 583 additions and 84 deletions
--- a/src/applications/project/controller/PhabricatorProjectEditController.php
+++ b/src/applications/project/controller/PhabricatorProjectEditController.php
@@ -3,10 +3,111 @@
 final class PhabricatorProjectEditController
  extends PhabricatorProjectController {

+  private $engine;
+
+  public function setEngine(PhabricatorProjectEditEngine $engine) {
+    $this->engine = $engine;
+    return $this;
+  }
+
+  public function getEngine() {
+    return $this->engine;
+  }
+
  public function handleRequest(AphrontRequest $request) {
-    return id(new PhabricatorProjectEditEngine())
-      ->setController($this)
-      ->buildResponse();
+    $viewer = $this->getViewer();
+
+    $engine = id(new PhabricatorProjectEditEngine())
+      ->setController($this);
+
+    $this->setEngine($engine);
+
+    $id = $request->getURIData('id');
+    if (!$id) {
+      $parent_id = head($request->getArr('parent'));
+      if (!$parent_id) {
+        $parent_id = $request->getStr('parent');
+      }
+
+      if ($parent_id) {
+        $is_milestone = false;
+      } else {
+        $parent_id = head($request->getArr('milestone'));
+        if (!$parent_id) {
+          $parent_id = $request->getStr('milestone');
+        }
+        $is_milestone = true;
+      }
+
+      if ($parent_id) {
+        $query = id(new PhabricatorProjectQuery())
+          ->setViewer($viewer)
+          ->requireCapabilities(
+            array(
+              PhabricatorPolicyCapability::CAN_VIEW,
+              PhabricatorPolicyCapability::CAN_EDIT,
+            ));
+
+        if (ctype_digit($parent_id)) {
+          $query->withIDs(array($parent_id));
+        } else {
+          $query->withPHIDs(array($parent_id));
+        }
+
+        $parent = $query->executeOne();
+
+        if ($is_milestone) {
+          if (!$parent->supportsMilestones()) {
+            $cancel_uri = "/project/milestones/{$parent_id}/";
+            return $this->newDialog()
+              ->setTitle(pht('No Milestones'))
+              ->appendParagraph(
+                pht('You can not add milestones to this project.'))
+              ->addCancelButton($cancel_uri);
+          }
+          $engine->setMilestoneProject($parent);
+        } else {
+          if (!$parent->supportsSubprojects()) {
+            $cancel_uri = "/project/subprojects/{$parent_id}/";
+            return $this->newDialog()
+              ->setTitle(pht('No Subprojects'))
+              ->appendParagraph(
+                pht('You can not add subprojects to this project.'))
+              ->addCancelButton($cancel_uri);
+          }
+          $engine->setParentProject($parent);
+        }
+
+        $this->setProject($parent);
+      }
+    }
+
+    return $engine->buildResponse();
+  }
+
+  protected function buildApplicationCrumbs() {
+    $crumbs = parent::buildApplicationCrumbs();
+
+    $engine = $this->getEngine();
+    if ($engine) {
+      $parent = $engine->getParentProject();
+      if ($parent) {
+        $id = $parent->getID();
+        $crumbs->addTextCrumb(
+          pht('Subprojects'),
+          $this->getApplicationURI("subprojects/{$id}/"));
+      }
+
+      $milestone = $engine->getMilestoneProject();
+      if ($milestone) {
+        $id = $milestone->getID();
+        $crumbs->addTextCrumb(
+          pht('Milestones'),
+          $this->getApplicationURI("milestones/{$id}/"));
+      }
+    }
+
+    return $crumbs;
  }

 }